issue_comments

Table actions

7 rows where issue = 1695809136 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Backend registration does not match docs, and is no longer specifiable in maturin pyproject toml · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1535941525 https://github.com/pydata/xarray/issues/7816#issuecomment-1535941525 https://api.github.com/repos/pydata/xarray/issues/7816 IC_kwDOAMm_X85bjJuV kmuehlbauer 5821660 2023-05-05T08:55:42Z 2023-05-05T08:55:42Z MEMBER

@gauteh No worries, glad it works now!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend registration does not match docs, and is no longer specifiable in maturin pyproject toml 1695809136
1535931753 https://github.com/pydata/xarray/issues/7816#issuecomment-1535931753 https://api.github.com/repos/pydata/xarray/issues/7816 IC_kwDOAMm_X85bjHVp gauteh 56827 2023-05-05T08:46:42Z 2023-05-05T08:46:42Z NONE

Hi,

I forgot to rebuild the package after removing the BACKEND_... line. With only the line in pyproject.toml it works as it should! My mistake. Thanks for the patience.

Regards, Gaute

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend registration does not match docs, and is no longer specifiable in maturin pyproject toml 1695809136
1535724636 https://github.com/pydata/xarray/issues/7816#issuecomment-1535724636 https://api.github.com/repos/pydata/xarray/issues/7816 IC_kwDOAMm_X85biUxc kmuehlbauer 5821660 2023-05-05T05:46:46Z 2023-05-05T05:46:46Z MEMBER

@gauteh Yes, please provide as much information as possible. It is also of interest, how you installed the package and what Python environment you are using (eg. system python, conda, venv etc.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend registration does not match docs, and is no longer specifiable in maturin pyproject toml 1695809136
1535716950 https://github.com/pydata/xarray/issues/7816#issuecomment-1535716950 https://api.github.com/repos/pydata/xarray/issues/7816 IC_kwDOAMm_X85biS5W gauteh 56827 2023-05-05T05:29:10Z 2023-05-05T05:29:10Z NONE

Hi,

Yes, I tried that, but I then got the same error as if I kept that line in the old format. I'll do a few tests and post the proper error here.

Gaute 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend registration does not match docs, and is no longer specifiable in maturin pyproject toml 1695809136
1535596259 https://github.com/pydata/xarray/issues/7816#issuecomment-1535596259 https://api.github.com/repos/pydata/xarray/issues/7816 IC_kwDOAMm_X85bh1bj kmuehlbauer 5821660 2023-05-05T01:46:12Z 2023-05-05T01:46:12Z MEMBER

@gauteh You would probably have to delete this line:

https://github.com/gauteh/hidefix/blob/main/python/hidefix/xarray.py#L192

As @headtr1ck already explained, it is all handled via plugin system to be able to handle duplicate engine names on discovery by the python metadata. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend registration does not match docs, and is no longer specifiable in maturin pyproject toml 1695809136
1535432806 https://github.com/pydata/xarray/issues/7816#issuecomment-1535432806 https://api.github.com/repos/pydata/xarray/issues/7816 IC_kwDOAMm_X85bhNhm gauteh 56827 2023-05-04T21:23:31Z 2023-05-04T21:23:31Z NONE

If I do not manually add the backend to the array, but only have this line in https://github.com/gauteh/hidefix/blob/main/pyproject.toml#L29:

[project.entry-points."xarray.backends"] hidefix = "hidefix.xarray:HidefixBackendEntrypoint"

which is only what is supported by pyproject.toml/maturin I get an error where xarray expected a tuple and cannot parse the entrypoint, not just the adderss to the entrypoint - as it used to be (back in January at least). 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend registration does not match docs, and is no longer specifiable in maturin pyproject toml 1695809136
1535358946 https://github.com/pydata/xarray/issues/7816#issuecomment-1535358946 https://api.github.com/repos/pydata/xarray/issues/7816 IC_kwDOAMm_X85bg7fi headtr1ck 43316012 2023-05-04T20:18:51Z 2023-05-04T20:24:26Z COLLABORATOR

I am not sure what exactly is not working. The BACKEND_ENTRYPOINTS is not a public API and is only used for xarrays internal backends. In the documentation that you have linked it is explained on how to register your project, which is purely in the setup.cfg/pyproject.toml, no need to manipulate xarray internal objects.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Backend registration does not match docs, and is no longer specifiable in maturin pyproject toml 1695809136

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);