issue_comments

Table actions

3 rows where issue = 1694956396 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Task naming for general chunkmanagers · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1536054499 https://github.com/pydata/xarray/issues/7813#issuecomment-1536054499 https://api.github.com/repos/pydata/xarray/issues/7813 IC_kwDOAMm_X85bjlTj tomwhite 85085 2023-05-05T10:30:38Z 2023-05-05T10:30:38Z CONTRIBUTOR

Ah I understand better now. This makes sense - if ChunkManager has a name then the implementation could use that to name tasks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Task naming for general chunkmanagers 1694956396
1535108194 https://github.com/pydata/xarray/issues/7813#issuecomment-1535108194 https://api.github.com/repos/pydata/xarray/issues/7813 IC_kwDOAMm_X85bf-Ri TomNicholas 35968931 2023-05-04T17:07:15Z 2023-05-04T17:07:15Z MEMBER

If you hover over a node in the SVG representation you'll get a tooltip that shows the call stack and the line number of the top-level user function that invoked the computation. Does that help at all?

That's neat!

When you create a dask graph of xarray operations, the tasks in the graph get useful names according the name of the DataArray they operate on

I realise now that this is not true - but can we make it true for cubed in xarray? Using cubed with xarray creates array's with names like array-002, but couldn't we use the dataarray's .name attribute to give this node of the graph the name "U" for example?

BTW should this be moved to a cubed issue?

I raised it here because it relates to an unfinished part of #7019 - where there is still dask-specific logic for naming individual tasks. I think that to solve this we will need to alter xarray code to allow ChunkManager objects to decide how they want to name their tasks, but using information passed from xarray (i.e. DataArray.name).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Task naming for general chunkmanagers 1694956396
1534281206 https://github.com/pydata/xarray/issues/7813#issuecomment-1534281206 https://api.github.com/repos/pydata/xarray/issues/7813 IC_kwDOAMm_X85bc0X2 tomwhite 85085 2023-05-04T08:22:05Z 2023-05-04T08:22:05Z CONTRIBUTOR

If you hover over a node in the SVG representation you'll get a tooltip that shows the call stack and the line number of the top-level user function that invoked the computation. Does that help at all? (That said, I'm open to changing the way it is displayed, or how tasks are named in general.)

BTW should this be moved to a cubed issue?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Task naming for general chunkmanagers 1694956396

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);