issue_comments

Table actions

3 rows where issue = 168876028 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • rc 0.8: register_dataset_accessor silently ignores AttributeError · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
236955760 https://github.com/pydata/xarray/issues/933#issuecomment-236955760 https://api.github.com/repos/pydata/xarray/issues/933 MDEyOklzc3VlQ29tbWVudDIzNjk1NTc2MA== fmaussion 10050469 2016-08-02T16:12:27Z 2016-08-02T16:12:27Z MEMBER

Thanks @shoyer !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rc 0.8: register_dataset_accessor silently ignores AttributeError 168876028
236950918 https://github.com/pydata/xarray/issues/933#issuecomment-236950918 https://api.github.com/repos/pydata/xarray/issues/933 MDEyOklzc3VlQ29tbWVudDIzNjk1MDkxOA== shoyer 1217238 2016-08-02T15:58:12Z 2016-08-02T15:58:12Z MEMBER

This is surprisingly tricky! See these StackOverflow posts for details: http://stackoverflow.com/questions/11116896/python-why-is-getattr-catching-attributeerrors http://stackoverflow.com/questions/15401180/using-getattr-and-meeting-expected-behaviour-for-subclasses

Because we define __getattr__, which we need to enable accessing variables with attribute syntax, it looks like the best we can do is re-raise the AttributeError as something else :(. So that's what I did in #935.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rc 0.8: register_dataset_accessor silently ignores AttributeError 168876028
236911947 https://github.com/pydata/xarray/issues/933#issuecomment-236911947 https://api.github.com/repos/pydata/xarray/issues/933 MDEyOklzc3VlQ29tbWVudDIzNjkxMTk0Nw== max-sixty 5635139 2016-08-02T13:56:53Z 2016-08-02T13:56:53Z MEMBER

Yes at the moment it catches the AttributeError, and raises a new Error here. I think it could super up in __getattr__, and that would raise the original error, but would need to test to confirm

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   rc 0.8: register_dataset_accessor silently ignores AttributeError 168876028

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);