issue_comments

Table actions

4 rows where issue = 168754274 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Dataset creation requires tuple, list treated differently · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
457895845 https://github.com/pydata/xarray/issues/929#issuecomment-457895845 https://api.github.com/repos/pydata/xarray/issues/929 MDEyOklzc3VlQ29tbWVudDQ1Nzg5NTg0NQ== stale[bot] 26384082 2019-01-27T07:32:11Z 2019-01-27T07:32:11Z NONE

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity If this issue remains relevant, please comment here; otherwise it will be marked as closed automatically

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset creation requires tuple, list treated differently 168754274
236736739 https://github.com/pydata/xarray/issues/929#issuecomment-236736739 https://api.github.com/repos/pydata/xarray/issues/929 MDEyOklzc3VlQ29tbWVudDIzNjczNjczOQ== shoyer 1217238 2016-08-01T23:15:28Z 2016-08-01T23:15:28Z MEMBER

This difference is certainly intentional. You're right that we currently don't explicitly state how we handle lists or numpy arrays in the docs -- that should be fixed.

At one point, we did have heuristics that did this sort of fallback logic (allowing lists, and checking the length of the tuple/list). But we eventually removed these checks, because this sort of value dependent behavior makes code difficult to predict. At least now it always behaves consistently when given a list or a tuple.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset creation requires tuple, list treated differently 168754274
236727385 https://github.com/pydata/xarray/issues/929#issuecomment-236727385 https://api.github.com/repos/pydata/xarray/issues/929 MDEyOklzc3VlQ29tbWVudDIzNjcyNzM4NQ== mcgibbon 12307589 2016-08-01T22:28:48Z 2016-08-01T22:29:07Z CONTRIBUTOR

A simple way is to try creating a Data Array by assuming it's metadata, and if it fails then assume it's data. However, this will probably "work" too often on lists it shouldn't. A better heuristic is that if the list is of length 2 or 3, and the first element is an iterable of strings, and the second element contains data (is a list or numpy array), and the optional third element is a map/dictionary, then the list is probably metadata. You might also require that the second element isn't the same length as the first element, in the case that they're both lists (in case someone wants a 2x2 DataArray of string labels that they're constructing from a list of lists).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset creation requires tuple, list treated differently 168754274
236726151 https://github.com/pydata/xarray/issues/929#issuecomment-236726151 https://api.github.com/repos/pydata/xarray/issues/929 MDEyOklzc3VlQ29tbWVudDIzNjcyNjE1MQ== fmaussion 10050469 2016-08-01T22:23:03Z 2016-08-01T22:23:03Z MEMBER

it may be better to do some sanity checking when a list is passed to figure out whether the list is data or as above

I guess that this is the difficult part. How to know if the list is data or "as above"?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset creation requires tuple, list treated differently 168754274

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);