issue_comments

Table actions

3 rows where issue = 1674818753 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Supplying multidimensional initial guess to `curvefit` · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1537140981 https://github.com/pydata/xarray/issues/7768#issuecomment-1537140981 https://api.github.com/repos/pydata/xarray/issues/7768 IC_kwDOAMm_X85bnuj1 mgunyho 20118130 2023-05-06T13:18:47Z 2023-05-06T13:18:47Z CONTRIBUTOR

I implemented this for p0 in #7821. I used your idea of passing p0 as part of *args. It's maybe a tiny bit hacky to put two things in *args and then reconstruct them based on the lengths, but not too bad.

I can also do this for the bounds, just didn't have time to do it yet. How do you think the multidimensional bounds should be passed? As a tuple of arrays, or as an array of tuples, or something else? To me, it would make most sense to pass them as tuples of "things that can be broadcast", so that e.g. the lower bound of can be a scalar 0, but the upper bound could vary.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Supplying multidimensional initial guess to `curvefit` 1674818753
1516681755 https://github.com/pydata/xarray/issues/7768#issuecomment-1516681755 https://api.github.com/repos/pydata/xarray/issues/7768 IC_kwDOAMm_X85aZrob slevang 39069044 2023-04-20T17:16:39Z 2023-04-20T17:16:39Z CONTRIBUTOR

This should be doable. I think we would have to rework the apply_ufunc wrapper to pass p0 and bounds as DataArrays through *args instead of simple dictionaries throughkwargs, so that apply_ufunc can broadcast them and handle dask chunks.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Supplying multidimensional initial guess to `curvefit` 1674818753
1514662357 https://github.com/pydata/xarray/issues/7768#issuecomment-1514662357 https://api.github.com/repos/pydata/xarray/issues/7768 IC_kwDOAMm_X85aR-nV welcome[bot] 30606887 2023-04-19T12:37:55Z 2023-04-19T12:37:55Z NONE

Thanks for opening your first issue here at xarray! Be sure to follow the issue template! If you have an idea for a solution, we would really welcome a Pull Request with proposed changes. See the Contributing Guide for more. It may take us a while to respond here, but we really value your contribution. Contributors like you help make xarray better. Thank you!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Supplying multidimensional initial guess to `curvefit` 1674818753

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);