issue_comments

Table actions

6 rows where issue = 1657036222 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • flox performance regression for cftime resampling · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1505403088 https://github.com/pydata/xarray/issues/7730#issuecomment-1505403088 https://api.github.com/repos/pydata/xarray/issues/7730 IC_kwDOAMm_X85ZuqDQ dcherian 2448579 2023-04-12T14:43:15Z 2023-04-12T14:43:15Z MEMBER

Thanks for the report! I think we should add your example as a benchmark.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   flox performance regression for cftime resampling 1657036222
1505309893 https://github.com/pydata/xarray/issues/7730#issuecomment-1505309893 https://api.github.com/repos/pydata/xarray/issues/7730 IC_kwDOAMm_X85ZuTTF mathause 10194086 2023-04-12T13:47:19Z 2023-04-12T13:47:19Z MEMBER

Thanks for looking into this!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   flox performance regression for cftime resampling 1657036222
1499878014 https://github.com/pydata/xarray/issues/7730#issuecomment-1499878014 https://api.github.com/repos/pydata/xarray/issues/7730 IC_kwDOAMm_X85ZZlJ- dcherian 2448579 2023-04-07T02:56:29Z 2023-04-07T02:56:29Z MEMBER

Also because your groups are sorted, engine='flox' is faster

```python gb = da.groupby("time.year")

using max

xr.set_options(use_flox=True) %timeit gb.max("time") %timeit gb.max("time", engine="flox")

xr.set_options(use_flox=False) %timeit gb.max("time") ```

177 ms ± 3.24 ms per loop (mean ± std. dev. of 7 runs, 1 loop each) 11.9 ms ± 471 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) 18.5 ms ± 629 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   flox performance regression for cftime resampling 1657036222
1499872700 https://github.com/pydata/xarray/issues/7730#issuecomment-1499872700 https://api.github.com/repos/pydata/xarray/issues/7730 IC_kwDOAMm_X85ZZj28 dcherian 2448579 2023-04-07T02:45:24Z 2023-04-07T02:49:41Z MEMBER

The slowness is basically a bunch of copies happening in align, broadcast, and transpose. It's made a lot worse for this case, because we take CFTimeIndex and cast it back to CFTimeIndex, repeating all the validity checks.

And then there's https://github.com/xarray-contrib/flox/issues/222

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   flox performance regression for cftime resampling 1657036222
1499263329 https://github.com/pydata/xarray/issues/7730#issuecomment-1499263329 https://api.github.com/repos/pydata/xarray/issues/7730 IC_kwDOAMm_X85ZXPFh mathause 10194086 2023-04-06T15:36:32Z 2023-04-06T15:36:32Z MEMBER

Of course - I added it above.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   flox performance regression for cftime resampling 1657036222
1498971031 https://github.com/pydata/xarray/issues/7730#issuecomment-1498971031 https://api.github.com/repos/pydata/xarray/issues/7730 IC_kwDOAMm_X85ZWHuX dcherian 2448579 2023-04-06T12:18:50Z 2023-04-06T12:18:50Z MEMBER

Thanks can you add version info please

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   flox performance regression for cftime resampling 1657036222

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);