issue_comments

Table actions

8 rows where issue = 1655782486 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • `pandas=2.0` support · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1504093110 https://github.com/pydata/xarray/pull/7724#issuecomment-1504093110 https://api.github.com/repos/pydata/xarray/issues/7724 IC_kwDOAMm_X85ZpqO2 dcherian 2448579 2023-04-11T21:07:32Z 2023-04-11T21:07:32Z MEMBER

I think we can double check that the only failures are cftimeindex, restore the pin, then merge, and then remove the pin in #7731 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `pandas=2.0` support 1655782486
1504083577 https://github.com/pydata/xarray/pull/7724#issuecomment-1504083577 https://api.github.com/repos/pydata/xarray/issues/7724 IC_kwDOAMm_X85Zpn55 keewis 14808389 2023-04-11T21:00:05Z 2023-04-11T21:00:05Z MEMBER

no, mypy should be fine, as the CI version does not complain and I assume whatever the hook is reporting is also present on main (I didn't check, though).

As far as I can tell, the only thing left is another round of reviews.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `pandas=2.0` support 1655782486
1503671262 https://github.com/pydata/xarray/pull/7724#issuecomment-1503671262 https://api.github.com/repos/pydata/xarray/issues/7724 IC_kwDOAMm_X85ZoDPe jsignell 4806877 2023-04-11T15:58:48Z 2023-04-11T15:58:48Z CONTRIBUTOR

Is there anything I can do to help out on this? It sounds like the blocker is mypy?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `pandas=2.0` support 1655782486
1501150705 https://github.com/pydata/xarray/pull/7724#issuecomment-1501150705 https://api.github.com/repos/pydata/xarray/issues/7724 IC_kwDOAMm_X85Zeb3x headtr1ck 43316012 2023-04-09T15:09:37Z 2023-04-09T15:09:37Z COLLABORATOR

Locally it always works, it segfaults in CI, which makes it impossible to debug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `pandas=2.0` support 1655782486
1501135058 https://github.com/pydata/xarray/pull/7724#issuecomment-1501135058 https://api.github.com/repos/pydata/xarray/issues/7724 IC_kwDOAMm_X85ZeYDS keewis 14808389 2023-04-09T13:57:19Z 2023-04-09T13:57:19Z MEMBER

I think we could check if the newest mypy still segfaults or not...

it didn't for me when I ran the hook, but that might just have been luck. To confirm, we'd need a PR that unpins mypy and potentially fixes all the errors that popped up since.

The mypy hook didn't take that long, but I guess it's the accumulated time that counts. Also, I learned today that the black-jupyter hook does all that black does plus format notebooks, so removing id: black should also shave off a bit.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `pandas=2.0` support 1655782486
1500907146 https://github.com/pydata/xarray/pull/7724#issuecomment-1500907146 https://api.github.com/repos/pydata/xarray/issues/7724 IC_kwDOAMm_X85ZdgaK headtr1ck 43316012 2023-04-08T14:53:42Z 2023-04-08T14:53:42Z COLLABORATOR

@Illviljan, @headtr1ck, I just noticed that the CI version of mypy is pinned to <0.990, but the pre-commit hook is at 1.1.1. Is that intentional / known? Running the hook also exposes quite a few typing errors.

I think this is because of https://github.com/pydata/xarray/issues/7270

The pre-commit hook of mypy should be disabled anyway because it takes too long to run (should be actually much faster since mypy >=1).

I think we could check if the newest mypy still segfaults or not...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `pandas=2.0` support 1655782486
1500113295 https://github.com/pydata/xarray/pull/7724#issuecomment-1500113295 https://api.github.com/repos/pydata/xarray/issues/7724 IC_kwDOAMm_X85ZaemP keewis 14808389 2023-04-07T09:25:49Z 2023-04-07T09:25:49Z MEMBER

@Illviljan, @headtr1ck, I just noticed that the CI version of mypy is pinned to <0.990, but the pre-commit hook is at 1.1.1. Is that intentional / known? Running the hook also exposes quite a few typing errors.

Otherwise this should be ready for a final review, and the failing datetime-related tests will be fixed by #7731.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `pandas=2.0` support 1655782486
1498929670 https://github.com/pydata/xarray/pull/7724#issuecomment-1498929670 https://api.github.com/repos/pydata/xarray/issues/7724 IC_kwDOAMm_X85ZV9oG keewis 14808389 2023-04-06T11:40:12Z 2023-04-06T11:40:12Z MEMBER

It seems this fixes the failing tests unrelated to the datetime64 range.

Regarding the failing doctests, I decided to cast the values of arr.dt.<field> to int64 to keep the API unchanged. However, if we decide to follow pandas and return int32 I'm happy to make that change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `pandas=2.0` support 1655782486

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);