issue_comments

Table actions

2 rows where issue = 1655483374 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Conflicting _FillValue and missing_value on write · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1498490570 https://github.com/pydata/xarray/issues/7722#issuecomment-1498490570 https://api.github.com/repos/pydata/xarray/issues/7722 IC_kwDOAMm_X85ZUSbK kmuehlbauer 5821660 2023-04-06T04:55:02Z 2023-04-06T04:55:02Z MEMBER

The recommendation is to use _FillValue if there is only one value describing missing/fillvalue.

https://cfconventions.org/Data/cf-conventions/cf-conventions-1.10/cf-conventions.html#missing-data

It's also written that missing_value is

This attribute is not treated in any special way by the library or conforming generic applications, but is often useful documentation and may be used by specific applications.

https://docs.unidata.ucar.edu/netcdf-c/current/attribute_conventions.html

Not sure, if xarray is a conforming generic application or a specific application.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Conflicting _FillValue and missing_value on write 1655483374
1498404409 https://github.com/pydata/xarray/issues/7722#issuecomment-1498404409 https://api.github.com/repos/pydata/xarray/issues/7722 IC_kwDOAMm_X85ZT9Y5 dcherian 2448579 2023-04-06T02:26:41Z 2023-04-06T02:26:41Z MEMBER

how about not adding _FillValue when missing_value is present? Is that a good idea? Is it standards compliant?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Conflicting _FillValue and missing_value on write 1655483374

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);