issue_comments

Table actions

7 rows where issue = 1644759739 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • How xarray handles missing values · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1494684558 https://github.com/pydata/xarray/pull/7694#issuecomment-1494684558 https://api.github.com/repos/pydata/xarray/issues/7694 IC_kwDOAMm_X85ZFxOO harshitha1201 97012127 2023-04-03T17:08:13Z 2023-04-03T17:08:13Z CONTRIBUTOR

Thank you!! @TomNicholas and @headtr1ck for updating the commit

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   How xarray handles missing values 1644759739
1491540395 https://github.com/pydata/xarray/pull/7694#issuecomment-1491540395 https://api.github.com/repos/pydata/xarray/issues/7694 IC_kwDOAMm_X85Y5xmr harshitha1201 97012127 2023-03-31T08:42:52Z 2023-03-31T08:42:52Z CONTRIBUTOR

@headtr1ck Read the docs build is failing. Is it due to issue #7703. Or the fault is on my side.

Yes, that is this issue.

okay!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   How xarray handles missing values 1644759739
1491538813 https://github.com/pydata/xarray/pull/7694#issuecomment-1491538813 https://api.github.com/repos/pydata/xarray/issues/7694 IC_kwDOAMm_X85Y5xN9 headtr1ck 43316012 2023-03-31T08:41:37Z 2023-03-31T08:41:37Z COLLABORATOR

@headtr1ck Read the docs build is failing. Is it due to issue #7703. Or the fault is on my side.

Yes, that is this issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   How xarray handles missing values 1644759739
1491537685 https://github.com/pydata/xarray/pull/7694#issuecomment-1491537685 https://api.github.com/repos/pydata/xarray/issues/7694 IC_kwDOAMm_X85Y5w8V harshitha1201 97012127 2023-03-31T08:40:43Z 2023-03-31T08:40:43Z CONTRIBUTOR

@headtr1ck Read the docs build is failing. Is it due to issue #7703. Or the fault is on my side.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   How xarray handles missing values 1644759739
1490794513 https://github.com/pydata/xarray/pull/7694#issuecomment-1490794513 https://api.github.com/repos/pydata/xarray/issues/7694 IC_kwDOAMm_X85Y27gR harshitha1201 97012127 2023-03-30T19:08:35Z 2023-03-30T19:08:35Z CONTRIBUTOR

@TomNicholas I have added explanation on computation.rst I have added a summary on faq.rst

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   How xarray handles missing values 1644759739
1488734179 https://github.com/pydata/xarray/pull/7694#issuecomment-1488734179 https://api.github.com/repos/pydata/xarray/issues/7694 IC_kwDOAMm_X85YvEfj TomNicholas 35968931 2023-03-29T14:28:12Z 2023-03-29T14:28:12Z MEMBER

Hi @harshitha1201 - thanks for this!

We do already have a section covering these methods in https://docs.xarray.dev/en/stable/user-guide/computation.html#missing-values. I suggest that we don't need to duplicate all of this information on the FAQ page.

That said the examples and explanation you have written here are still useful! Perhaps they can either be used to improve the page I just linked, or go into the docstrings of those particular methods.

For the FAQ page instead I think we probably just want to provide a summary in a couple of sentences and a link to the more detailed information on specific methods. The summary should mention that - xarray can handle missing values, - it uses np.NaN to do so, - most computation methods will automatically handle missing values appropriately, - aggregation methods have a skipna argument, - plotting will just leave them as blank spaces (link to plotting page), - we have a set of special methods for manipulating missing and filling values (link to here).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   How xarray handles missing values 1644759739
1488035772 https://github.com/pydata/xarray/pull/7694#issuecomment-1488035772 https://api.github.com/repos/pydata/xarray/issues/7694 IC_kwDOAMm_X85YsZ-8 harshitha1201 97012127 2023-03-29T06:51:19Z 2023-03-29T06:51:19Z CONTRIBUTOR

@TomNicholas please review

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   How xarray handles missing values 1644759739

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);