issue_comments

Table actions

12 rows where issue = 1623776623 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Added an introduction to the reshaping documentation · 12 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1492154899 https://github.com/pydata/xarray/pull/7623#issuecomment-1492154899 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Y8HoT nishtha981 92522516 2023-03-31T15:39:07Z 2023-03-31T15:39:07Z CONTRIBUTOR

Sure! I'll keep that in mind next time! Thank you

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623
1492125602 https://github.com/pydata/xarray/pull/7623#issuecomment-1492125602 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Y8Aei TomNicholas 35968931 2023-03-31T15:26:10Z 2023-03-31T15:26:10Z MEMBER

Thanks @nishtha981 !

I just realised after merging that this PR should in theory have had a corresponding entry in the what's new page, as all PRs are supposed to have.

We won't worry about that this time, but try and remember to add it next time! That way you will also be listed as a contributor on the what's new page.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623
1492114238 https://github.com/pydata/xarray/pull/7623#issuecomment-1492114238 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Y79s- nishtha981 92522516 2023-03-31T15:21:20Z 2023-03-31T15:21:20Z CONTRIBUTOR

Hey! @TomNicholas All the checks have passed. Can you please merge the pr?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623
1491365165 https://github.com/pydata/xarray/pull/7623#issuecomment-1491365165 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Y5G0t headtr1ck 43316012 2023-03-31T06:22:28Z 2023-03-31T06:22:28Z COLLABORATOR

I am not sure if pinning works as pydata-sphinx-theme had some private function which sphinx-book-theme was using but now it cannot. Will probably have to wait for a new release of sphinx-book-theme.

See #7703

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623
1491345771 https://github.com/pydata/xarray/pull/7623#issuecomment-1491345771 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Y5CFr nishtha981 92522516 2023-03-31T06:04:02Z 2023-03-31T06:04:02Z CONTRIBUTOR

I am not sure if pinning works as pydata-sphinx-theme had some private function which sphinx-book-theme was using but now it cannot. Will probably have to wait for a new release of sphinx-book-theme.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623
1491306549 https://github.com/pydata/xarray/pull/7623#issuecomment-1491306549 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Y44g1 nishtha981 92522516 2023-03-31T05:12:06Z 2023-03-31T05:12:06Z CONTRIBUTOR

@TomNicholas Do I pin the sphinx-book-theme version 0.3.0

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623
1491278724 https://github.com/pydata/xarray/pull/7623#issuecomment-1491278724 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Y4xuE TomNicholas 35968931 2023-03-31T04:40:58Z 2023-03-31T04:40:58Z MEMBER

I've also just told the readthedocs to rebuild just now

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623
1491278420 https://github.com/pydata/xarray/pull/7623#issuecomment-1491278420 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Y4xpU TomNicholas 35968931 2023-03-31T04:40:23Z 2023-03-31T04:40:23Z MEMBER

Hi @nishtha981 - that's great that you identified what was causing the docs ci builds to fail! I was wondering why that was!

Fixing this for xarray may require more than just re-running the ci. For example it might require us to pin a particular version of a library (here sphinx_book_theme) in order to guarantee the CI works again. If it doesn't work immediately now, what we normally do is to open a new github issue on xarray's issue tracker to track the problem. That way if the problem comes up in multiple PRs we can just refer all of them back to the one issue, until it gets resolved completely.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623
1491274387 https://github.com/pydata/xarray/pull/7623#issuecomment-1491274387 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Y4wqT nishtha981 92522516 2023-03-31T04:34:34Z 2023-03-31T04:35:49Z CONTRIBUTOR

Hey @TomNicholas I've found that the issue https://github.com/executablebooks/sphinx-book-theme/issues/711 was causing an issue with the test cases of my pr. It has been merged now so I'll be making an empty push so that the test cases can run again.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623
1490695151 https://github.com/pydata/xarray/pull/7623#issuecomment-1490695151 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Y2jPv nishtha981 92522516 2023-03-30T17:50:31Z 2023-03-30T17:50:31Z CONTRIBUTOR

Hey! @TomNicholas the documentation tests are failing Would you be able to merge the pr despite the issue or can you guide me on how to solve it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623
1490687686 https://github.com/pydata/xarray/pull/7623#issuecomment-1490687686 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Y2hbG TomNicholas 35968931 2023-03-30T17:43:55Z 2023-03-30T17:43:55Z MEMBER

I've made a final edit to remove the mention of a specific method in the intro, and remove some blanks lines. This looks good to me now so I'll merge it! Thanks @nishtha981 !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623
1489741624 https://github.com/pydata/xarray/pull/7623#issuecomment-1489741624 https://api.github.com/repos/pydata/xarray/issues/7623 IC_kwDOAMm_X85Yy6c4 nishtha981 92522516 2023-03-30T05:58:33Z 2023-03-30T05:58:33Z CONTRIBUTOR

@headtr1ck @TomNicholas Please do review the pr! Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added an introduction to the reshaping documentation 1623776623

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);