issue_comments

Table actions

7 rows where issue = 1619835929 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • dataset attrs list of strings to_netcdf() error · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1472500948 https://github.com/pydata/xarray/issues/7608#issuecomment-1472500948 https://api.github.com/repos/pydata/xarray/issues/7608 IC_kwDOAMm_X85XxJTU dcherian 2448579 2023-03-16T18:19:42Z 2023-03-16T18:19:42Z MEMBER

In that case an allow list copied from scipy seems best. This file really just uses scipy so that seems appropriate

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset attrs list of strings to_netcdf() error 1619835929
1472454634 https://github.com/pydata/xarray/issues/7608#issuecomment-1472454634 https://api.github.com/repos/pydata/xarray/issues/7608 IC_kwDOAMm_X85Xw9_q DocOtak 868027 2023-03-16T17:57:28Z 2023-03-16T17:57:28Z CONTRIBUTOR

I think 1d arrays of other data types are allowed... it's just that the 1d dim value is hidden from you in attributes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset attrs list of strings to_netcdf() error 1619835929
1472407806 https://github.com/pydata/xarray/issues/7608#issuecomment-1472407806 https://api.github.com/repos/pydata/xarray/issues/7608 IC_kwDOAMm_X85Xwyj- dcherian 2448579 2023-03-16T17:31:29Z 2023-03-16T17:31:29Z MEMBER

Seems like we could raise if utils.is_scalar(value)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset attrs list of strings to_netcdf() error 1619835929
1472379128 https://github.com/pydata/xarray/issues/7608#issuecomment-1472379128 https://api.github.com/repos/pydata/xarray/issues/7608 IC_kwDOAMm_X85Xwrj4 DocOtak 868027 2023-03-16T17:12:43Z 2023-03-16T17:12:43Z CONTRIBUTOR

@dcherian would the following be a good place to put this check/raise? https://github.com/pydata/xarray/blob/b36819b1ed4f74ba8e254f2baa790303ef350e4a/xarray/backends/netcdf3.py#L75-L84

scipy has a short list of allowed attr dtypes, would we want our check to be in the form of an allow list? I guess does scipy implement all that is allowed in netcdf3?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset attrs list of strings to_netcdf() error 1619835929
1470063056 https://github.com/pydata/xarray/issues/7608#issuecomment-1470063056 https://api.github.com/repos/pydata/xarray/issues/7608 IC_kwDOAMm_X85Xn2HQ dcherian 2448579 2023-03-15T13:59:58Z 2023-03-15T13:59:58Z MEMBER

Can we raise a nicer error message here suggesting the user install netcdf4-python

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset attrs list of strings to_netcdf() error 1619835929
1469544529 https://github.com/pydata/xarray/issues/7608#issuecomment-1469544529 https://api.github.com/repos/pydata/xarray/issues/7608 IC_kwDOAMm_X85Xl3hR kmuehlbauer 5821660 2023-03-15T08:14:59Z 2023-03-15T08:14:59Z MEMBER

@DocOtak Memory served well :+1:, stepping to open issues yesterday: https://github.com/pydata/xarray/issues/3374. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset attrs list of strings to_netcdf() error 1619835929
1464795339 https://github.com/pydata/xarray/issues/7608#issuecomment-1464795339 https://api.github.com/repos/pydata/xarray/issues/7608 IC_kwDOAMm_X85XTwDL DocOtak 868027 2023-03-11T02:19:32Z 2023-03-11T02:19:32Z CONTRIBUTOR

Are you able to install the netcdf4 package in your environment? If my memory serves, the scipy netCDF implementation only supports netCDF3 and array of strings in attributes are a netcdf4 feature.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   dataset attrs list of strings to_netcdf() error 1619835929

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);