issue_comments

Table actions

10 rows where issue = 158902764 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • ENH: more control on colorbar · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
321592640 https://github.com/pydata/xarray/pull/872#issuecomment-321592640 https://api.github.com/repos/pydata/xarray/issues/872 MDEyOklzc3VlQ29tbWVudDMyMTU5MjY0MA== rvalenzuelar 6894066 2017-08-10T15:49:55Z 2017-08-10T15:49:55Z NONE

Could you give an example on how to use this functionality when using faceting plots? For example, I have a 4 column figure and I would like to have the colorbar on top. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: more control on colorbar 158902764
224939397 https://github.com/pydata/xarray/pull/872#issuecomment-224939397 https://api.github.com/repos/pydata/xarray/issues/872 MDEyOklzc3VlQ29tbWVudDIyNDkzOTM5Nw== shoyer 1217238 2016-06-09T15:52:53Z 2016-06-09T15:52:53Z MEMBER

Thanks @fmaussion !

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: more control on colorbar 158902764
224939203 https://github.com/pydata/xarray/pull/872#issuecomment-224939203 https://api.github.com/repos/pydata/xarray/issues/872 MDEyOklzc3VlQ29tbWVudDIyNDkzOTIwMw== shoyer 1217238 2016-06-09T15:52:18Z 2016-06-09T15:52:18Z MEMBER

Yeah, I'm a big fan of squash-on-merge. It's much easier than forcing contributors to master git rebase.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: more control on colorbar 158902764
224933442 https://github.com/pydata/xarray/pull/872#issuecomment-224933442 https://api.github.com/repos/pydata/xarray/issues/872 MDEyOklzc3VlQ29tbWVudDIyNDkzMzQ0Mg== fmaussion 10050469 2016-06-09T15:33:31Z 2016-06-09T15:33:46Z MEMBER

Yes, ok.

[OT]: Some people on the mpl mailing list said it was a dangerous feature of github but I didn't understand why. I guess that for large PRs it might be useful to keep the intermediate commits, but for the majority of the cases it makes the git history much clearer I think.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: more control on colorbar 158902764
224931775 https://github.com/pydata/xarray/pull/872#issuecomment-224931775 https://api.github.com/repos/pydata/xarray/issues/872 MDEyOklzc3VlQ29tbWVudDIyNDkzMTc3NQ== jhamman 2443309 2016-06-09T15:28:14Z 2016-06-09T15:28:14Z MEMBER

No need to rebase. We can squash on the github side now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: more control on colorbar 158902764
224931210 https://github.com/pydata/xarray/pull/872#issuecomment-224931210 https://api.github.com/repos/pydata/xarray/issues/872 MDEyOklzc3VlQ29tbWVudDIyNDkzMTIxMA== fmaussion 10050469 2016-06-09T15:26:22Z 2016-06-09T15:26:22Z MEMBER

Right, I always forget about this one. Let me know if I should rebase, too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: more control on colorbar 158902764
224922211 https://github.com/pydata/xarray/pull/872#issuecomment-224922211 https://api.github.com/repos/pydata/xarray/issues/872 MDEyOklzc3VlQ29tbWVudDIyNDkyMjIxMQ== shoyer 1217238 2016-06-09T14:59:02Z 2016-06-09T14:59:02Z MEMBER

This looks great. We just need a brief note for what's new now. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: more control on colorbar 158902764
224845352 https://github.com/pydata/xarray/pull/872#issuecomment-224845352 https://api.github.com/repos/pydata/xarray/issues/872 MDEyOklzc3VlQ29tbWVudDIyNDg0NTM1Mg== fmaussion 10050469 2016-06-09T09:31:40Z 2016-06-09T09:31:40Z MEMBER

@shoyer I added some tests and and implemented @jhamman 's comments. I am not a big fan of raising an error when keywords are set and not used, but I don't have a use case for this either so I implemented it as requested ;)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: more control on colorbar 158902764
224806584 https://github.com/pydata/xarray/pull/872#issuecomment-224806584 https://api.github.com/repos/pydata/xarray/issues/872 MDEyOklzc3VlQ29tbWVudDIyNDgwNjU4NA== jhamman 2443309 2016-06-09T05:55:54Z 2016-06-09T05:55:54Z MEMBER

This is great. I had two small comments and agree that it could use some tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: more control on colorbar 158902764
224719161 https://github.com/pydata/xarray/pull/872#issuecomment-224719161 https://api.github.com/repos/pydata/xarray/issues/872 MDEyOklzc3VlQ29tbWVudDIyNDcxOTE2MQ== shoyer 1217238 2016-06-08T20:35:52Z 2016-06-08T20:35:52Z MEMBER

This looks great -- it is possible to add a test for some of this functionality? Take a look at the existing plotting tests and see if there's anything you can do easily.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ENH: more control on colorbar 158902764

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);