issue_comments

Table actions

3 rows where issue = 1571143098 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Zarr: drop "source" and "original_shape" from encoding · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1416862557 https://github.com/pydata/xarray/pull/7500#issuecomment-1416862557 https://api.github.com/repos/pydata/xarray/issues/7500 IC_kwDOAMm_X85Uc5td max-sixty 5635139 2023-02-04T22:20:47Z 2023-02-04T22:20:47Z MEMBER

Yes, very much makes sense to copy the netCDF behavior.

I'll let @dcherian comment on the tradeoff. Either warning when reading or adding a prefix sound reasonable (but also probably can be separate PRs, this still seems like an improvement)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr: drop "source" and "original_shape" from encoding 1571143098
1416861976 https://github.com/pydata/xarray/pull/7500#issuecomment-1416861976 https://api.github.com/repos/pydata/xarray/issues/7500 IC_kwDOAMm_X85Uc5kY observingClouds 43613877 2023-02-04T22:16:49Z 2023-02-04T22:16:49Z CONTRIBUTOR

I'm just mimicking the netCDF4 driver here. Maybe one could use less probable attributes than source? Maybe adding a prefix like xarray_ to those attributes? I'm open to suggestions.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr: drop "source" and "original_shape" from encoding 1571143098
1416861145 https://github.com/pydata/xarray/pull/7500#issuecomment-1416861145 https://api.github.com/repos/pydata/xarray/issues/7500 IC_kwDOAMm_X85Uc5XZ max-sixty 5635139 2023-02-04T22:11:16Z 2023-02-04T22:11:16Z MEMBER

Thanks @observingClouds !

I wasn't paying attention to the original issue so this might be missing things — is there any concern that either of those are on the original zarr and we'd be removing them?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr: drop "source" and "original_shape" from encoding 1571143098

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);