issue_comments

Table actions

9 rows where issue = 1562408536 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Data linked from https://docs.xarray.dev/en/stable/examples/ROMS_ocean_model.html is unavaible · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1412411490 https://github.com/pydata/xarray/issues/7486#issuecomment-1412411490 https://api.github.com/repos/pydata/xarray/issues/7486 IC_kwDOAMm_X85UL7Bi mwestphal 3129530 2023-02-01T17:08:31Z 2023-02-01T17:08:31Z NONE

or the entire section (personally, I would lean towards the latter).

That was definitely not my goal, as I was about to publish a blog linking to that very section as an example. Of course, i'm merely a user here.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Data linked from https://docs.xarray.dev/en/stable/examples/ROMS_ocean_model.html is unavaible 1562408536
1412396521 https://github.com/pydata/xarray/issues/7486#issuecomment-1412396521 https://api.github.com/repos/pydata/xarray/issues/7486 IC_kwDOAMm_X85UL3Xp keewis 14808389 2023-02-01T17:00:14Z 2023-02-01T17:00:14Z MEMBER

thanks, that makes sense to me. I think that rules out option 3, so now we only need to decide whether we remove only the data url or the entire section (personally, I would lean towards the latter).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Data linked from https://docs.xarray.dev/en/stable/examples/ROMS_ocean_model.html is unavaible 1562408536
1412254964 https://github.com/pydata/xarray/issues/7486#issuecomment-1412254964 https://api.github.com/repos/pydata/xarray/issues/7486 IC_kwDOAMm_X85ULUz0 hetland 2599958 2023-02-01T15:30:32Z 2023-02-01T15:30:32Z NONE

In terms of maintenance burden, I would say that the future of the THREDDS server is uncertain. I am no longer at TAMU, so no longer in charge of keeping it up. And there are other issues that may make it difficult to keep up, even in the near term.

So, I think relying on the accessability of this particular dataset even in the near term is not a good idea, unfortunately.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Data linked from https://docs.xarray.dev/en/stable/examples/ROMS_ocean_model.html is unavaible 1562408536
1412214395 https://github.com/pydata/xarray/issues/7486#issuecomment-1412214395 https://api.github.com/repos/pydata/xarray/issues/7486 IC_kwDOAMm_X85ULK57 keewis 14808389 2023-02-01T15:07:15Z 2023-02-01T15:07:15Z MEMBER

1 is the status quo (minus the removal of the data server url): the cells are set to "raw", so they are not run. We don't want to hit the server during CI anyways, as hitting the server would slow down the docs build too much.

It seems like there's at least two people who tried to follow the subsetting (or otherwise play with the raw data), so the section does have some value. However, I don't know how this compares to the burden of maintaining it, especially since we don't run it in CI.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Data linked from https://docs.xarray.dev/en/stable/examples/ROMS_ocean_model.html is unavaible 1562408536
1412165245 https://github.com/pydata/xarray/issues/7486#issuecomment-1412165245 https://api.github.com/repos/pydata/xarray/issues/7486 IC_kwDOAMm_X85UK-59 hetland 2599958 2023-02-01T14:37:22Z 2023-02-01T14:37:22Z NONE

So, that bit of code that references the THREDDS server was just to explain how the (heavily subsetted) data was processed and put into the xarray example datasets. It's not necessary for the example to run, though it could be interesting. I have three solutions, roughly in order of my preference:

  1. Keep the subsetting code for reference, but just quote it, so it does not run. Delete the reference to the data server as the subsetting can be considered generic and just for reference.
  2. Delete the whole section on subsetting.
  3. Update the data server to http://pong.tamu.edu/thredds/dodsC/NcML/txla_hindcast_agg_chunk. I put this last, as I am concerned the data server will move or be disrupted again, and so this woudl be something that would need to be perpetually fixed. Not ideal.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Data linked from https://docs.xarray.dev/en/stable/examples/ROMS_ocean_model.html is unavaible 1562408536
1409080221 https://github.com/pydata/xarray/issues/7486#issuecomment-1409080221 https://api.github.com/repos/pydata/xarray/issues/7486 IC_kwDOAMm_X85T_Nud dcherian 2448579 2023-01-30T18:05:09Z 2023-01-30T18:05:09Z MEMBER

Oh oops, sorry!

Perhaps we just delete that section unless @hetland has a suggestion

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Data linked from https://docs.xarray.dev/en/stable/examples/ROMS_ocean_model.html is unavaible 1562408536
1409066939 https://github.com/pydata/xarray/issues/7486#issuecomment-1409066939 https://api.github.com/repos/pydata/xarray/issues/7486 IC_kwDOAMm_X85T_Ke7 keewis 14808389 2023-01-30T17:56:04Z 2023-01-30T17:56:04Z MEMBER

don't we do that already? As far as I can tell, the url is there to explain where we got the data from and what preprocessing was done. Unless I'm missing something?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Data linked from https://docs.xarray.dev/en/stable/examples/ROMS_ocean_model.html is unavaible 1562408536
1409024668 https://github.com/pydata/xarray/issues/7486#issuecomment-1409024668 https://api.github.com/repos/pydata/xarray/issues/7486 IC_kwDOAMm_X85T_AKc dcherian 2448579 2023-01-30T17:25:34Z 2023-01-30T17:25:34Z MEMBER

Ah we can replace that line with xr.tutorial.load_dataset("ROMS_example") it looks identical. @mwestphal this would be a easy PR if you're up for it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Data linked from https://docs.xarray.dev/en/stable/examples/ROMS_ocean_model.html is unavaible 1562408536
1408703594 https://github.com/pydata/xarray/issues/7486#issuecomment-1408703594 https://api.github.com/repos/pydata/xarray/issues/7486 IC_kwDOAMm_X85T9xxq keewis 14808389 2023-01-30T14:17:55Z 2023-01-30T14:17:55Z MEMBER

the data server is out of our control, so we can't fix this ourselves, unfortunately.

We might be able to look for a different server for that model, but I don't know enough about the model to do that myself. Any ideas, @pydata/xarray?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Data linked from https://docs.xarray.dev/en/stable/examples/ROMS_ocean_model.html is unavaible 1562408536

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);