issue_comments

Table actions

6 rows where issue = 1552630830 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Many tests fail: AttributeError: 'cftime._cftime.DatetimeJulian' object has no attribute 'daysinmonth' · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1413965407 https://github.com/pydata/xarray/issues/7467#issuecomment-1413965407 https://api.github.com/repos/pydata/xarray/issues/7467 IC_kwDOAMm_X85UR2Zf dcherian 2448579 2023-02-02T15:53:43Z 2023-02-02T15:53:43Z MEMBER

Oh apparently you can place constraints on optional packages: https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#run-constrained

Seems like we just need to update the meta.yaml in the feedstock appropriately.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Many tests fail: AttributeError: 'cftime._cftime.DatetimeJulian' object has no attribute 'daysinmonth' 1552630830
1413761706 https://github.com/pydata/xarray/issues/7467#issuecomment-1413761706 https://api.github.com/repos/pydata/xarray/issues/7467 IC_kwDOAMm_X85UREqq mathause 10194086 2023-02-02T13:39:01Z 2023-02-02T13:39:01Z MEMBER

I think the problem is that there is no way to pin optional dependecies in conda. I understand your frustration but it's not practical to explicitly test for all of this in the code. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Many tests fail: AttributeError: 'cftime._cftime.DatetimeJulian' object has no attribute 'daysinmonth' 1552630830
1400664859 https://github.com/pydata/xarray/issues/7467#issuecomment-1400664859 https://api.github.com/repos/pydata/xarray/issues/7467 IC_kwDOAMm_X85TfHMb yurivict 271906 2023-01-23T16:52:36Z 2023-01-23T16:52:53Z NONE

(Obviously the above comment only applies if cftime installed; technically cftime is an optional dependency)

But if it breaks when a wrong cftime version is present you probably should check its version and not use it or fail when it is too old.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Many tests fail: AttributeError: 'cftime._cftime.DatetimeJulian' object has no attribute 'daysinmonth' 1552630830
1400659638 https://github.com/pydata/xarray/issues/7467#issuecomment-1400659638 https://api.github.com/repos/pydata/xarray/issues/7467 IC_kwDOAMm_X85TfF62 yurivict 271906 2023-01-23T16:48:28Z 2023-01-23T16:48:28Z NONE

$ pkg info | grep cftime py39-cftime-1.0.3.4_1 Time-handling functionality from netcdf4-python

requirements.txt doesn't have cftime in it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Many tests fail: AttributeError: 'cftime._cftime.DatetimeJulian' object has no attribute 'daysinmonth' 1552630830
1400379742 https://github.com/pydata/xarray/issues/7467#issuecomment-1400379742 https://api.github.com/repos/pydata/xarray/issues/7467 IC_kwDOAMm_X85TeBle spencerkclark 6628425 2023-01-23T13:47:30Z 2023-01-23T13:47:30Z MEMBER

(Obviously the above comment only applies if cftime installed; technically cftime is an optional dependency)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Many tests fail: AttributeError: 'cftime._cftime.DatetimeJulian' object has no attribute 'daysinmonth' 1552630830
1400370743 https://github.com/pydata/xarray/issues/7467#issuecomment-1400370743 https://api.github.com/repos/pydata/xarray/issues/7467 IC_kwDOAMm_X85Td_Y3 spencerkclark 6628425 2023-01-23T13:42:50Z 2023-01-23T13:46:59Z MEMBER

@yurivict could you show the output of xarray.show_versions()? I suspect you are using an old version of cftime. Xarray requires a minimum version of 1.5.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Many tests fail: AttributeError: 'cftime._cftime.DatetimeJulian' object has no attribute 'daysinmonth' 1552630830

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);