issue_comments

Table actions

5 rows where issue = 155181260 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • roundtrip boolean datatype · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
220884679 https://github.com/pydata/xarray/pull/849#issuecomment-220884679 https://api.github.com/repos/pydata/xarray/issues/849 MDEyOklzc3VlQ29tbWVudDIyMDg4NDY3OQ== shoyer 1217238 2016-05-23T04:21:48Z 2016-05-23T04:21:48Z MEMBER

I think this is good to merge. Appveyor is definitely doing something strange here with the Python 3 build.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roundtrip boolean datatype 155181260
220884502 https://github.com/pydata/xarray/pull/849#issuecomment-220884502 https://api.github.com/repos/pydata/xarray/issues/849 MDEyOklzc3VlQ29tbWVudDIyMDg4NDUwMg== shoyer 1217238 2016-05-23T04:19:31Z 2016-05-23T04:19:31Z MEMBER

I think it's fine to write all booleans data using this encoding. It's pretty obvious how it works, and it's compatible with all versions of netCDf.

Unfortunately, netCDF-C libraries can't read variables with the enum dtype created by h5py for boolean data (https://github.com/Unidata/netcdf-c/issues/267), so I don't think we should encourage that option.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roundtrip boolean datatype 155181260
220657272 https://github.com/pydata/xarray/pull/849#issuecomment-220657272 https://api.github.com/repos/pydata/xarray/issues/849 MDEyOklzc3VlQ29tbWVudDIyMDY1NzI3Mg== jhamman 2443309 2016-05-20T16:43:39Z 2016-05-20T16:43:39Z MEMBER

One annoying potential inconsistency here is that it is possible to write boolean dtypes using h5py (which uses HDF5 enums), which is different from how we do things here.

okay, so do we want/need to insert some logic into the h5py backend that handles the boolean type differently. I suppose this only matters for the write, reading from boolean (enum) types should be unaffected by this change. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roundtrip boolean datatype 155181260
220652754 https://github.com/pydata/xarray/pull/849#issuecomment-220652754 https://api.github.com/repos/pydata/xarray/issues/849 MDEyOklzc3VlQ29tbWVudDIyMDY1Mjc1NA== shoyer 1217238 2016-05-20T16:24:48Z 2016-05-20T16:24:48Z MEMBER

One annoying potential inconsistency here is that it is possible to write boolean dtypes using h5py (which uses HDF5 enums), which is different from how we do things here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roundtrip boolean datatype 155181260
219744691 https://github.com/pydata/xarray/pull/849#issuecomment-219744691 https://api.github.com/repos/pydata/xarray/issues/849 MDEyOklzc3VlQ29tbWVudDIxOTc0NDY5MQ== jhamman 2443309 2016-05-17T14:57:50Z 2016-05-17T14:57:50Z MEMBER

Note that the failing test appears to be a anaconda issue on Appveyor and is not related to this PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   roundtrip boolean datatype 155181260

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);