issue_comments

Table actions

5 rows where issue = 1548948097 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Typing of internal datatypes · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1397515014 https://github.com/pydata/xarray/issues/7457#issuecomment-1397515014 https://api.github.com/repos/pydata/xarray/issues/7457 IC_kwDOAMm_X85TTGMG Illviljan 14371165 2023-01-19T19:49:19Z 2023-01-19T19:49:19Z MEMBER

I feel like this has been mentioned before.

Yes, now I recall, it was here #6894.

I think it could be interesting to try out: https://github.com/pmeier/array-protocol

Another good read: https://github.com/data-apis/array-api/issues/229

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing of internal datatypes 1548948097
1397480084 https://github.com/pydata/xarray/issues/7457#issuecomment-1397480084 https://api.github.com/repos/pydata/xarray/issues/7457 IC_kwDOAMm_X85TS9qU TomNicholas 35968931 2023-01-19T19:14:04Z 2023-01-19T19:14:04Z MEMBER

But then da.data will be of this protocol type and not the array class that you assume it has. For internal type checking this is what we want but for the user this will be confusing.

When will the user be using this type annotation? Isn't all this typing stuff basically a dev feature (internally and downstream)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing of internal datatypes 1548948097
1397469153 https://github.com/pydata/xarray/issues/7457#issuecomment-1397469153 https://api.github.com/repos/pydata/xarray/issues/7457 IC_kwDOAMm_X85TS6_h headtr1ck 43316012 2023-01-19T19:05:08Z 2023-01-19T19:05:08Z COLLABORATOR

Doesn't the python array api standard effort have some type of duck array protocol we could import? I feel like this has been mentioned before. Then we would start with @Illviljan 's suggestion and replace it with the correct duck array protocol later.

But then da.data will be of this protocol type and not the array class that you assume it has. For internal type checking this is what we want but for the user this will be confusing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing of internal datatypes 1548948097
1397465527 https://github.com/pydata/xarray/issues/7457#issuecomment-1397465527 https://api.github.com/repos/pydata/xarray/issues/7457 IC_kwDOAMm_X85TS6G3 TomNicholas 35968931 2023-01-19T19:02:09Z 2023-01-19T19:02:09Z MEMBER

Doesn't the python array api standard effort have some type of duck array protocol we could import? I feel like this has been mentioned before. Then we would start with @Illviljan 's suggestion and replace it with the correct duck array protocol later.

We might also consider that in the context of different distributed array backends dask arrays define a more specific API that includes methods like .chunk() too. Standardisation of that is a long-term dream though, not an immediate problem.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing of internal datatypes 1548948097
1397074522 https://github.com/pydata/xarray/issues/7457#issuecomment-1397074522 https://api.github.com/repos/pydata/xarray/issues/7457 IC_kwDOAMm_X85TRapa Illviljan 14371165 2023-01-19T14:35:37Z 2023-01-19T14:35:37Z MEMBER

I've been thinking that a good and safe start on this issue is to replace all these raw Any's with T_DuckArray where T_DuckArray = Any. It won't help in the typing but it gives some traceability and makes it easier to determine what the intention was.

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing of internal datatypes 1548948097

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);