issue_comments

Table actions

6 rows where issue = 153066635 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Don't convert data with time units to timedeltas by default · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
239210661 https://github.com/pydata/xarray/issues/843#issuecomment-239210661 https://api.github.com/repos/pydata/xarray/issues/843 MDEyOklzc3VlQ29tbWVudDIzOTIxMDY2MQ== ocefpaf 950575 2016-08-11T16:14:28Z 2016-08-11T16:14:28Z CONTRIBUTOR

@shoyer the more I think about this the more I don't like the addition of extra keywords. Even though I would like this behavior to be the default one I really do not like the complexity I added here.

Closing this...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Don't convert data with time units to timedeltas by default 153066635
237430205 https://github.com/pydata/xarray/issues/843#issuecomment-237430205 https://api.github.com/repos/pydata/xarray/issues/843 MDEyOklzc3VlQ29tbWVudDIzNzQzMDIwNQ== ocefpaf 950575 2016-08-04T01:52:53Z 2016-08-04T01:52:53Z CONTRIBUTOR

Prototype is ready http://nbviewer.jupyter.org/gist/ocefpaf/cabdcb27a5ef7da1b6110327a5f03e17

I will polish this and send a PR soon.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Don't convert data with time units to timedeltas by default 153066635
237427041 https://github.com/pydata/xarray/issues/843#issuecomment-237427041 https://api.github.com/repos/pydata/xarray/issues/843 MDEyOklzc3VlQ29tbWVudDIzNzQyNzA0MQ== shoyer 1217238 2016-08-04T01:38:39Z 2016-08-04T01:38:39Z MEMBER

To answer your original question: yes, separate decode_timedeltasand decode_datetimes options seems like a sane way to handle this.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Don't convert data with time units to timedeltas by default 153066635
237416540 https://github.com/pydata/xarray/issues/843#issuecomment-237416540 https://api.github.com/repos/pydata/xarray/issues/843 MDEyOklzc3VlQ29tbWVudDIzNzQxNjU0MA== ocefpaf 950575 2016-08-04T00:31:10Z 2016-08-04T00:31:10Z CONTRIBUTOR

No problem. I want to solve this anyways b/c it is quite awkward to keep converting back from timedeltas to time data. I will have a PR soon.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Don't convert data with time units to timedeltas by default 153066635
237416240 https://github.com/pydata/xarray/issues/843#issuecomment-237416240 https://api.github.com/repos/pydata/xarray/issues/843 MDEyOklzc3VlQ29tbWVudDIzNzQxNjI0MA== shoyer 1217238 2016-08-04T00:28:59Z 2016-08-04T00:28:59Z MEMBER

It's too late for v0.8.0, I'm afraid! I already tagged/uploaded the release and am about to send out the announcement.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Don't convert data with time units to timedeltas by default 153066635
237414886 https://github.com/pydata/xarray/issues/843#issuecomment-237414886 https://api.github.com/repos/pydata/xarray/issues/843 MDEyOklzc3VlQ29tbWVudDIzNzQxNDg4Ng== ocefpaf 950575 2016-08-04T00:19:31Z 2016-08-04T00:19:31Z CONTRIBUTOR

@shoyer is this what you have in mid? Replacing decode_time for decode_datetimes and decode_timedelta and then:

``` python if decode_datetimes and 'units' in attributes and 'since' in attributes['units']: units = pop_to(attributes, encoding, 'units') calendar = pop_to(attributes, encoding, 'calendar') data = DecodedCFDatetimeArray(data, units, calendar)

if decode_timedelta and attributes['units'] in TIME_UNITS:
    units = pop_to(attributes, encoding, 'units')
    data = DecodedCFTimedeltaArray(data, units)

```

To be honest I cannot see why someone might want to convert time data to a timedelta and I would be inclined to remove decode_timedelta instead. However, that may be my very biased view since such transformation does not make sense with my data :smile:

Do you have any advice? (I would like to try this before you release v0.8.0)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Don't convert data with time units to timedeltas by default 153066635

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);