issue_comments

Table actions

5 rows where issue = 1519552711 and user = 35968931 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • TomNicholas · 5 ✖

issue 1

  • Import datatree in xarray? · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1411454442 https://github.com/pydata/xarray/pull/7418#issuecomment-1411454442 https://api.github.com/repos/pydata/xarray/issues/7418 IC_kwDOAMm_X85UIRXq TomNicholas 35968931 2023-02-01T04:40:30Z 2023-02-01T04:40:30Z MEMBER

I think this PR is ready now, it just fails mypy (@Illviljan I added a py.typed file to datatree but the xarray mypy CI is still not happy with it).

Once this is merged we can push on with implementing open_datatree (https://github.com/pydata/xarray/pull/7437 @jthielen) and I can take a crack at fixing https://github.com/xarray-contrib/datatree/issues/146 in xarray in a follow-up PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Import datatree in xarray? 1519552711
1377905161 https://github.com/pydata/xarray/pull/7418#issuecomment-1377905161 https://api.github.com/repos/pydata/xarray/issues/7418 IC_kwDOAMm_X85SISoJ TomNicholas 35968931 2023-01-10T21:33:27Z 2023-01-10T21:33:27Z MEMBER

Integrating upstream into xarray might also help with people trying to open their nested data formats as a datatree objects, because then we can immediately begin integrating with xarray's backend engines.

See for example this datatree issue asking about opening grib files as a datatree. It would be nice to be able to do

open_datatree("data.grib", engine="cfgrib")

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Import datatree in xarray? 1519552711
1373101988 https://github.com/pydata/xarray/pull/7418#issuecomment-1373101988 https://api.github.com/repos/pydata/xarray/issues/7418 IC_kwDOAMm_X85R19-k TomNicholas 35968931 2023-01-06T03:35:36Z 2023-01-06T03:35:36Z MEMBER

Would it mean that if someone wants to later add any feature "x" or "y" into Xarray, they just need implementing the feature for Dataset (and possibly DataArray) and it will be guaranteed to work with Datatree?

Basically yes, it would immediately work with Datatree. Datatree currently implements most dataset methods by literally copying them and their docstrings, and they work by mapping the method over every node in the tree. We could integrate Datatree in such a way that the additional developer effort to get a method on dataset working on Datatree would be negligible (think adding a single element with the method name to an internal list, or copy-pasting a docstring).

I don't think it is ideal to have such non-synchronized state within Xarray itself.

This is an argument for waiting before integrating.

I'm just speaking generally from my experience of having struggled while doing some heavy refactoring in Xarray recently :)

I appreciate the input @benbovy! I think the main difference between this effort and your (heroic) indexes effort is that Datatree doesn't touch any existing API.

I guess my main concern is that integrating prematurely into Xarray might give a false sense of stability - I don't want to later realize I should redesign Datatree, and have people be annoyed because they thought it was as stable as the rest of xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Import datatree in xarray? 1519552711
1372806772 https://github.com/pydata/xarray/pull/7418#issuecomment-1372806772 https://api.github.com/repos/pydata/xarray/issues/7418 IC_kwDOAMm_X85R0150 TomNicholas 35968931 2023-01-05T21:36:25Z 2023-01-05T21:36:25Z MEMBER

Why? Are its dependencies different from Xarray?

No, datatree has no additional dependencies. I was just asking because if we went for the "import from second repository" plan we may want to test that the import works as part of our CI. Not a major issue though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Import datatree in xarray? 1519552711
1372360850 https://github.com/pydata/xarray/pull/7418#issuecomment-1372360850 https://api.github.com/repos/pydata/xarray/issues/7418 IC_kwDOAMm_X85RzJCS TomNicholas 35968931 2023-01-05T15:24:58Z 2023-01-05T15:24:58Z MEMBER

There is also at least one bug in datatree that cannot be fixed without a (small) change to xarray, and having datatree as an optional import means I could fix it here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Import datatree in xarray? 1519552711

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);