issue_comments

Table actions

3 rows where issue = 1519552711 and user = 1197350 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • rabernat · 3 ✖

issue 1

  • Import datatree in xarray? · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1378079073 https://github.com/pydata/xarray/pull/7418#issuecomment-1378079073 https://api.github.com/repos/pydata/xarray/issues/7418 IC_kwDOAMm_X85SI9Fh rabernat 1197350 2023-01-11T00:34:03Z 2023-01-11T00:34:03Z MEMBER

we should carefully evaluate the datatree API to make sure we won't want to change it soon

I agree with this. We could use the PR process for this review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Import datatree in xarray? 1519552711
1372822656 https://github.com/pydata/xarray/pull/7418#issuecomment-1372822656 https://api.github.com/repos/pydata/xarray/issues/7418 IC_kwDOAMm_X85R05yA rabernat 1197350 2023-01-05T21:50:53Z 2023-01-05T21:50:53Z MEMBER

I personally favor just copying the code into Xarray and archiving the old repo.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Import datatree in xarray? 1519552711
1372802153 https://github.com/pydata/xarray/pull/7418#issuecomment-1372802153 https://api.github.com/repos/pydata/xarray/issues/7418 IC_kwDOAMm_X85R00xp rabernat 1197350 2023-01-05T21:31:33Z 2023-01-05T21:31:33Z MEMBER
  • At what stage is atatree "ready" to moved in here? At what stage should it become encouraged public API?

My opinion is that Datatree should move into Xarray now, ideally in a way that does not disrupt any existing user code, and that Datatree should become a first-class Xarray object (together with DataArray, and Dataset). Since it's a new feature, we don't necessarily have to be super conservative here. I think it is more than good enough / stable enough in its current state.

  • What's a good way to slowly roll the feature out?

Since Datatree sits above DataArray and Dataset, it should not interfere with any of our existing API. As long as test coverage is good, documentation is solid, and the code style matches the rest of Xarray, I think we can just bring it in.

  • How do I decrease the bus factor on datatree's code? Can I get some code reviews during the merging process? 🙏

I think that it is inevitable that you Tom will be the main owner of the Datatree code at the beginning (as @shoyer was of all of Xarray when he first released it). Over time, if people use it, some fraction of users will become maintainers, starting with the existing dev team.

  • Should I make a new CI environment just for testing datatree stuff?

Why? Are its dependencies different from Xarray?

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Import datatree in xarray? 1519552711

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);