issue_comments

Table actions

2 rows where issue = 1503573351 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • keewis · 2 ✖

issue 1

  • Follow keep_attrs in Dataset binary ops · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1384168506 https://github.com/pydata/xarray/pull/7391#issuecomment-1384168506 https://api.github.com/repos/pydata/xarray/issues/7391 IC_kwDOAMm_X85SgLw6 keewis 14808389 2023-01-16T14:46:03Z 2023-01-16T14:46:03Z MEMBER

I guess this means that we have two options: just assume this does not cause anything else to fail to get this PR to work (but then this PR would be blocked until we fixed every use of the global keep_attrs in a separate PR), or we ignore str-valued / callable keep_attrs for now and merge your initial proposal.

Option 2 seems easier, so I'd suggest we go with that?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Follow keep_attrs in Dataset binary ops 1503573351
1378595020 https://github.com/pydata/xarray/pull/7391#issuecomment-1378595020 https://api.github.com/repos/pydata/xarray/issues/7391 IC_kwDOAMm_X85SK7DM keewis 14808389 2023-01-11T11:16:02Z 2023-01-11T11:16:02Z MEMBER

The missing documentation for this in apply_ufunc is definitely an oversight, so PRs very welcome!

consider this as new feature, not just a bugfix?

I always struggle with classifying changes, but I guess the more we add onto this PR, the more it becomes a new feature.

implement this for xarray.Variable too?

probably. The only reason this is not done yet is because nobody took the time to actually do it. So, once again: PRs very welcome!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Follow keep_attrs in Dataset binary ops 1503573351

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);