issue_comments

Table actions

4 rows where issue = 1498386428 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Some alignment optimizations · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1372796814 https://github.com/pydata/xarray/pull/7382#issuecomment-1372796814 https://api.github.com/repos/pydata/xarray/issues/7382 IC_kwDOAMm_X85R0zeO Illviljan 14371165 2023-01-05T21:26:13Z 2023-01-05T21:26:13Z MEMBER

Thanks, @benbovy !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Some alignment optimizations 1498386428
1357719218 https://github.com/pydata/xarray/pull/7382#issuecomment-1357719218 https://api.github.com/repos/pydata/xarray/issues/7382 IC_kwDOAMm_X85Q7Say benbovy 4160723 2022-12-19T14:03:56Z 2022-12-19T14:03:56Z MEMBER

I don't know if the optimizations added here will benefit a large set of use cases (it took 6 months before seeing an issue report), but it is worth for at least a few of them. This is ready I think (added some benchmarks).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Some alignment optimizations 1498386428
1353473644 https://github.com/pydata/xarray/pull/7382#issuecomment-1353473644 https://api.github.com/repos/pydata/xarray/issues/7382 IC_kwDOAMm_X85QrF5s Illviljan 14371165 2022-12-15T17:43:29Z 2022-12-15T17:43:38Z MEMBER

No benchmark is catching this? Maybe we can add a small one in https://github.com/pydata/xarray/blob/main/asv_bench/benchmarks/indexing.py ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Some alignment optimizations 1498386428
1353034657 https://github.com/pydata/xarray/pull/7382#issuecomment-1353034657 https://api.github.com/repos/pydata/xarray/issues/7382 IC_kwDOAMm_X85Qpauh benbovy 4160723 2022-12-15T13:05:55Z 2022-12-15T13:05:55Z MEMBER

Quick benchmark taking the example in #7376 (it seems even much faster than in version 2022.3.0!)

```python

version 2022.3.0

%timeit ds.assign(foo=~ds["d3"])

22.5 ms ± 1.96 ms per loop (mean ± std. dev. of 7 runs, 100 loops each)

main branch

%timeit ds.assign(foo=~ds["d3"])

193 ms ± 1.35 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

this PR

%timeit ds.assign(foo=~ds["d3"])

1.01 ms ± 10.7 µs per loop (mean ± std. dev. of 7 runs, 1,000 loops each)

```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Some alignment optimizations 1498386428

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);