issue_comments

Table actions

3 rows where issue = 1490160140 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Improve performance for backend datetime handling · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1381988483 https://github.com/pydata/xarray/pull/7374#issuecomment-1381988483 https://api.github.com/repos/pydata/xarray/issues/7374 IC_kwDOAMm_X85SX3iD headtr1ck 43316012 2023-01-13T15:03:34Z 2023-01-13T15:03:34Z COLLABORATOR

Great, thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve performance for backend datetime handling 1490160140
1381077264 https://github.com/pydata/xarray/pull/7374#issuecomment-1381077264 https://api.github.com/repos/pydata/xarray/issues/7374 IC_kwDOAMm_X85SUZEQ dcherian 2448579 2023-01-12T22:46:41Z 2023-01-12T22:46:41Z MEMBER

Looks like an improvement on my machine

before after ratio [4f3128bb] [898b8728] <main> <mypy_conventions> - 244±7ms 184±3ms 0.76 dataset_io.IOReadCustomEngine.time_open_dataset(None)

IOReadSingleFile hasn't changed significantly

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve performance for backend datetime handling 1490160140
1379571092 https://github.com/pydata/xarray/pull/7374#issuecomment-1379571092 https://api.github.com/repos/pydata/xarray/issues/7374 IC_kwDOAMm_X85SOpWU Illviljan 14371165 2023-01-11T22:33:55Z 2023-01-11T22:33:55Z MEMBER

Benchmark are improved if I understand the logs correctly. Unfortunately not significant enough to make ASV report it though. The ratio has to be >1.5 and the improvements on .time_open_dataset are around 1.3-1.4.

```

PR:

[ 50.85%] ··· dataset_io.IOReadCustomEngine.time_open_dataset ok [ 50.85%] ··· ======== ========= chunks
-------- --------- None 130±1ms {} 689±6ms ======== =========

[ 54.69%] ··· dataset_io.IOReadSingleFile.time_read_dataset ok [ 54.69%] ··· ========= ============= ============= -- chunks
--------- --------------------------- engine None {}
========= ============= ============= scipy 5.48±0.04ms 6.91±0.01ms netcdf4 2.93±0.04ms 4.32±0.02ms ========= ============= =============

Baseline:

[ 75.85%] ··· dataset_io.IOReadCustomEngine.time_open_dataset ok [ 75.85%] ··· ======== =========== chunks
-------- ----------- None 177±0.5ms {} 737±3ms
======== ===========

[ 79.69%] ··· dataset_io.IOReadSingleFile.time_read_dataset ok [ 79.69%] ··· ========= ============ ============ -- chunks
--------- ------------------------- engine None {}
========= ============ ============ scipy 4.47±0.6ms 5.74±0.7ms netcdf4 4.39±0.7ms 5.82±0.6ms ========= ============ ============ ```

```

PR:

[ 50.85%] ··· dataset_io.IOReadCustomEngine.time_open_dataset ok [ 50.85%] ··· ======== ========== chunks
-------- ---------- None 149±4ms
{} 797±20ms ======== ==========

[ 54.69%] ··· dataset_io.IOReadSingleFile.time_read_dataset ok [ 54.69%] ··· ========= ============ ============= -- chunks
--------- -------------------------- engine None {}
========= ============ ============= scipy 6.57±0.2ms 7.77±0.01ms netcdf4 3.71±0.1ms 6.17±0.5ms ========= ============ =============

Baseline:

[ 75.85%] ··· dataset_io.IOReadCustomEngine.time_open_dataset ok [ 75.85%] ··· ======== ========== chunks
-------- ---------- None 204±2ms
{} 857±20ms ======== ==========

[ 79.69%] ··· dataset_io.IOReadSingleFile.time_read_dataset ok [ 79.69%] ··· ========= ============ ============ -- chunks
--------- ------------------------- engine None {}
========= ============ ============ scipy 5.53±1ms 7.12±0.8ms netcdf4 4.96±0.6ms 6.74±0.8ms ========= ============ ============

```

```

PR:

[ 50.85%] ··· dataset_io.IOReadCustomEngine.time_open_dataset ok [ 50.85%] ··· ======== ============ chunks
-------- ------------ None 204±8ms
{} 1.20±0.04s ======== ============

[ 54.69%] ··· dataset_io.IOReadSingleFile.time_read_dataset ok [ 54.69%] ··· ========= ============ ============ -- chunks
--------- ------------------------- engine None {}
========= ============ ============ netcdf4 6.86±0.7ms 9.81±0.6ms scipy 6.74±1ms 9.10±1ms
========= ============ ============

Baseline:

[ 75.85%] ··· dataset_io.IOReadCustomEngine.time_open_dataset ok [ 75.85%] ··· ======== ============ chunks
-------- ------------ None 282±5ms
{} 1.20±0.04s ======== ============

[ 79.69%] ··· dataset_io.IOReadSingleFile.time_read_dataset ok [ 79.69%] ··· ========= ============ ============ -- chunks
--------- ------------------------- engine None {}
========= ============ ============ netcdf4 6.91±1ms 9.77±0.7ms scipy 6.91±0.7ms 9.11±1ms
========= ============ ============ ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve performance for backend datetime handling 1490160140

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);