issue_comments

Table actions

3 rows where issue = 1455771929 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • DataArray.reindex of empty array changes dtype from float32 to float64 · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1330164500 https://github.com/pydata/xarray/issues/7299#issuecomment-1330164500 https://api.github.com/repos/pydata/xarray/issues/7299 IC_kwDOAMm_X85PSLMU shoyer 1217238 2022-11-29T06:53:48Z 2022-11-29T06:53:48Z MEMBER

Difference between empty and non-empty arrays comes from different logic used for empty arrays in Variable._getitem_with_mask.

The problem itself can be solved by fixing dtypes.maybe_promote to return fill_value=np.float32('nan') instead of fill_value=np.nan on dtype('float32') input.

Thanks for the excellent report!

I agree, this sounds like a good fix to me.

I think something like the following would work: Replace the return line of maybe_promote python return np.dtype(dtype), fill_value with python dtype = np.dtype(dtype) fill_value = dtype.type(fill_value) return dtype, fill_value

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.reindex of empty array changes dtype from float32 to float64 1455771929
1329743185 https://github.com/pydata/xarray/issues/7299#issuecomment-1329743185 https://api.github.com/repos/pydata/xarray/issues/7299 IC_kwDOAMm_X85PQkVR dcherian 2448579 2022-11-28T20:46:50Z 2022-11-28T20:46:50Z MEMBER

The problem itself can be solved by fixing dtypes.maybe_promote to return fill_value=np.float32('nan') instead of fill_value=np.nan on dtype('float32') input.

This seems like better behaviour to me. @shoyer, what do you think?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.reindex of empty array changes dtype from float32 to float64 1455771929
1325508554 https://github.com/pydata/xarray/issues/7299#issuecomment-1325508554 https://api.github.com/repos/pydata/xarray/issues/7299 IC_kwDOAMm_X85PAafK eugene57 1482551 2022-11-23T18:42:54Z 2022-11-23T18:42:54Z NONE

Difference between empty and non-empty arrays comes from different logic used for empty arrays in Variable._getitem_with_mask.

The problem itself can be solved by fixing dtypes.maybe_promote to return fill_value=np.float32('nan') instead of fill_value=np.nan on dtype('float32') input.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.reindex of empty array changes dtype from float32 to float64 1455771929

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);