issue_comments

Table actions

6 rows where issue = 145243134 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • shoyer · 6 ✖

issue 1

  • Add drop=True option for where on Dataset and DataArray · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
207890803 https://github.com/pydata/xarray/pull/815#issuecomment-207890803 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNzg5MDgwMw== shoyer 1217238 2016-04-10T00:33:25Z 2016-04-10T00:33:25Z MEMBER

Thanks @pwolfram !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop=True option for where on Dataset and DataArray 145243134
205406043 https://github.com/pydata/xarray/pull/815#issuecomment-205406043 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNTQwNjA0Mw== shoyer 1217238 2016-04-04T17:28:12Z 2016-04-04T17:28:12Z MEMBER

looks good to me other than a few nits

Please also add a release note crediting yourself!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop=True option for where on Dataset and DataArray 145243134
204564456 https://github.com/pydata/xarray/pull/815#issuecomment-204564456 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDU2NDQ1Ng== shoyer 1217238 2016-04-01T21:00:31Z 2016-04-01T21:00:31Z MEMBER

+1 for drop=True

On Fri, Apr 1, 2016 at 1:59 PM, Phillip Wolfram notifications@github.com wrote:

@shoyer https://github.com/shoyer et al, I think @MaximilianR https://github.com/MaximilianR's suggestion makes sense. This would reduce the amount of code that has to be accounted for too and would be cleaner. Essentially have this method be called via array.where(mask, drop=True) instead of array.sel_where(mask).

All feedback on this proposal welcome.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/pydata/xarray/pull/815#issuecomment-204564228

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop=True option for where on Dataset and DataArray 145243134
204527062 https://github.com/pydata/xarray/pull/815#issuecomment-204527062 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDUyNzA2Mg== shoyer 1217238 2016-04-01T19:08:46Z 2016-04-01T19:10:15Z MEMBER

@MaximilianR In this example I used where to produce a map:

```

ds.states.where(ds.states == state_ids['California']).plot() ```

If I used sel_where, the plot would be automatically trimmed. That's the main usecase here. I don't think there is an equivalent shortcut in pandas.

@fmaussion that's correct that you cannot do lazy computation with the result of nonzero on a dask array. However, computing nonzero itself could be an expensive operation if the mask is large, and we could do that with dask.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop=True option for where on Dataset and DataArray 145243134
204519675 https://github.com/pydata/xarray/pull/815#issuecomment-204519675 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDUxOTY3NQ== shoyer 1217238 2016-04-01T18:50:41Z 2016-04-01T18:50:57Z MEMBER

At some point it might be useful to be able to use dask to compute the mask (with mask.data.nonzero()), so I made an issue for that: https://github.com/dask/dask/issues/1076

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop=True option for where on Dataset and DataArray 145243134
204499751 https://github.com/pydata/xarray/pull/815#issuecomment-204499751 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDQ5OTc1MQ== shoyer 1217238 2016-04-01T18:14:42Z 2016-04-01T18:14:42Z MEMBER

Yes, expanding the section on "where" seems like the right place to put this.

On Fri, Apr 1, 2016 at 11:08 AM, Phillip Wolfram notifications@github.com wrote:

@shoyer https://github.com/shoyer, I haven't added any specific documentation. Would you recommend doing so and if so, should this go near here https://github.com/pydata/xarray/blame/master/doc/indexing.rst#L265?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/pydata/xarray/pull/815#issuecomment-204498369

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add drop=True option for where on Dataset and DataArray 145243134

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);