issue_comments

Table actions

5 rows where issue = 1444440024 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Require to explicitly defining optional dimensions such as hue and markersize · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1405634513 https://github.com/pydata/xarray/pull/7277#issuecomment-1405634513 https://api.github.com/repos/pydata/xarray/issues/7277 IC_kwDOAMm_X85TyEfR Illviljan 14371165 2023-01-26T20:51:43Z 2023-01-26T20:51:43Z MEMBER 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Require to explicitly defining optional dimensions such as hue and markersize 1444440024
1399202401 https://github.com/pydata/xarray/pull/7277#issuecomment-1399202401 https://api.github.com/repos/pydata/xarray/issues/7277 IC_kwDOAMm_X85TZiJh Illviljan 14371165 2023-01-21T07:54:29Z 2023-01-21T07:54:29Z MEMBER

This has stalled for long enough. I'll merge this at the end of next week unless someone disagrees, this pretty much reverts to original ds.plot.scatter behaviour because defining less than x and y in ds.plot.scatter was never allowed before anyway.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Require to explicitly defining optional dimensions such as hue and markersize 1444440024
1321100829 https://github.com/pydata/xarray/pull/7277#issuecomment-1321100829 https://api.github.com/repos/pydata/xarray/issues/7277 IC_kwDOAMm_X85OvmYd Illviljan 14371165 2022-11-20T11:00:50Z 2022-11-20T11:00:50Z MEMBER

@dcherian, as you noted in that PR as well it's not just matplotlib but xarray too that does a lot of guessing already, x,y in plot2d for example. I was more concerned about consistency and believed we got closer to what the majority of the plotting functions does by guessing.

These are the coords that we currently guess in plot1d: https://github.com/pydata/xarray/blob/d6671dd414370d006254ba3156cb96256ce0e9c7/xarray/plot/dataarray_plot.py#L154 Should we remove them, (empty tuple) and let the user explicitly define all of them? If so should we remove any guessing in the other plot functions as well?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Require to explicitly defining optional dimensions such as hue and markersize 1444440024
1314068973 https://github.com/pydata/xarray/pull/7277#issuecomment-1314068973 https://api.github.com/repos/pydata/xarray/issues/7277 IC_kwDOAMm_X85OUxnt dcherian 2448579 2022-11-14T16:50:46Z 2022-11-14T16:50:46Z MEMBER

I disagree here, even though it runs contrary to what matplotlib does. It's better to ask users to be explicit about what they want.

We had this discussion a long time ago in one of my first PRs (!)(https://github.com/pydata/xarray/pull/1785)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Require to explicitly defining optional dimensions such as hue and markersize 1444440024
1310792821 https://github.com/pydata/xarray/pull/7277#issuecomment-1310792821 https://api.github.com/repos/pydata/xarray/issues/7277 IC_kwDOAMm_X85OIRx1 Illviljan 14371165 2022-11-10T19:26:44Z 2022-11-10T19:26:44Z MEMBER

@jorisvandenbossche, feel free to try out this PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Require to explicitly defining optional dimensions such as hue and markersize 1444440024

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);