issue_comments

Table actions

12 rows where issue = 1440280424 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments · 12 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1460637902 https://github.com/pydata/xarray/issues/7266#issuecomment-1460637902 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85XD5DO keewis 14808389 2023-03-08T18:16:31Z 2023-03-08T18:16:31Z MEMBER

closed by #7444

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424
1336172648 https://github.com/pydata/xarray/issues/7266#issuecomment-1336172648 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85PpGBo spencerkclark 6628425 2022-12-03T14:36:44Z 2022-12-03T14:36:44Z MEMBER

As I think about this more, it wouldn't be too hard for us to support the base argument even after pandas removes it, so perhaps this isn't so urgent (at least as far as deprecation is concerned; we still need to make updates for compatibility, however). The code to translate a base argument to an offset argument can be found here, and is all possible with public API functionality. I already did something similar for the CFTimeIndex resampling code in #7284.

Maybe you were already thinking along those lines @dcherian.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424
1335971694 https://github.com/pydata/xarray/issues/7266#issuecomment-1335971694 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85PoU9u spencerkclark 6628425 2022-12-02T23:56:55Z 2022-12-02T23:56:55Z MEMBER

Sorry I didn't get to adding the warning today. I'll try and put something together over the weekend so that it gets into the release after today's. I'm not sure exactly when pandas 2.0 will be out, but regardless I guess at least it could still be valuable for anyone who doesn't upgrade xarray and pandas at the same time.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424
1335522218 https://github.com/pydata/xarray/issues/7266#issuecomment-1335522218 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85PmnOq dcherian 2448579 2022-12-02T16:46:24Z 2022-12-02T16:46:24Z MEMBER

Should we add some sort of deprecation warning regarding the use of the base argument with future versions of pandas before the next release?

That would be nice. It seems like we could also just do it in a later release?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424
1335139569 https://github.com/pydata/xarray/issues/7266#issuecomment-1335139569 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85PlJzx spencerkclark 6628425 2022-12-02T12:03:27Z 2022-12-02T12:04:20Z MEMBER

Should we add some sort of deprecation warning regarding the use of the base argument with future versions of pandas before the next release?

(I did not end up restoring the pandas warning in #7284)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424
1323619141 https://github.com/pydata/xarray/issues/7266#issuecomment-1323619141 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85O5NNF keewis 14808389 2022-11-22T12:40:24Z 2022-11-22T12:40:24Z MEMBER

we've got a few more errors now: TypeError: DatetimeArray._generate_range() got an unexpected keyword argument 'closed'

I've renamed this issue to allow tracking more recent failures in new issues.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424
1312791661 https://github.com/pydata/xarray/issues/7266#issuecomment-1312791661 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85OP5xt keewis 14808389 2022-11-13T18:24:00Z 2022-11-13T18:24:32Z MEMBER

maybe we can extend the action / create a new one to open one issue per unique deprecation message. However, for that we'd need to log the warnings in the reportlog output, which as far as I can tell pytest-reportlog does not support at the moment.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424
1312768623 https://github.com/pydata/xarray/issues/7266#issuecomment-1312768623 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85OP0Jv spencerkclark 6628425 2022-11-13T16:21:28Z 2022-11-13T16:21:28Z MEMBER

Perhaps we can at least restore the warning in #7284 in case our next release happens to take place before the next pandas release to give users somewhat of a heads up. Apologies for being a bit out of the loop of #4292 at the time.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424
1312767572 https://github.com/pydata/xarray/issues/7266#issuecomment-1312767572 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85OPz5U spencerkclark 6628425 2022-11-13T16:16:52Z 2022-11-13T16:16:52Z MEMBER

I went ahead and actually implemented the origin and offset options for the CFTimeIndex version of resample as part of #7284. It might be good to finish that and then we can decide how we would like to handle the deprecation.

Maybe we should try to catch Deprecation warnings in the nightly builds and raise an error / Automatic issue, so we can fix things before they break.

I agree -- something like that would be useful in general. In this particular case it seems like we were aware of it at one point, but just lost track after silencing it initially for compatibility reasons (https://github.com/pydata/xarray/pull/4292#issuecomment-691665611). Unfortunately that means that this was silenced in user code as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424
1312552266 https://github.com/pydata/xarray/issues/7266#issuecomment-1312552266 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85OO_VK headtr1ck 43316012 2022-11-12T19:05:46Z 2022-11-12T19:06:10Z COLLABORATOR

We also still have https://github.com/pydata/xarray/issues/6985 open.

Maybe we should try to catch Deprecation warnings in the nightly builds and raise an error / Automatic issue, so we can fix things before they break.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424
1308705176 https://github.com/pydata/xarray/issues/7266#issuecomment-1308705176 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85OAUGY spencerkclark 6628425 2022-11-09T12:52:11Z 2022-11-09T12:53:13Z MEMBER

Yes, I think so too. I can look into it more this weekend. Clearly we need to change the code that relies on pandas immediately. For resampling with a CFTimeIndex I may create a separate issue for implementing these new arguments (we can probably get those tests passing in the meantime, however).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424
1308067260 https://github.com/pydata/xarray/issues/7266#issuecomment-1308067260 https://api.github.com/repos/pydata/xarray/issues/7266 IC_kwDOAMm_X85N94W8 dcherian 2448579 2022-11-09T01:24:59Z 2022-11-09T01:24:59Z MEMBER

Looks to be a result of https://github.com/pandas-dev/pandas/pull/49101/files

Seems like we have to change to origin or offset somewhere

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ⚠️ Nightly upstream-dev CI failed ⚠️: `pandas` removed deprecated keyword arguments 1440280424

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);