issue_comments

Table actions

2 rows where issue = 1434498245 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Remove setuptools-scm-git-archive, require setuptools-scm>=7 · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1302724471 https://github.com/pydata/xarray/pull/7253#issuecomment-1302724471 https://api.github.com/repos/pydata/xarray/issues/7253 IC_kwDOAMm_X85Npf93 mwtoews 895458 2022-11-03T22:01:49Z 2022-11-03T22:01:49Z CONTRIBUTOR

I've looked into this further, and what I see is that $Format:%(describe:tags=true)$ requires git 2.35.0 (January 2022) or later; see docs here. Earlier versions will just leave "%(describe:tags=true)" without substitution or error. I presume "git archive" would be running on newish GitHub actions versions of git.

As for the updated format with a numeric match, I don't think it makes any difference. Testing with git 2.38.1: $ git log -2 --format="%(describe:tags=true,match=*[0-9]*)" v2022.10.0-47-g2e6fab2f v2022.10.0-46-g6179d8e8 $ git log -2 --format="%(describe:tags=true)" v2022.10.0-47-g2e6fab2f v2022.10.0-46-g6179d8e8 but I've amended this PR with the new change to keep it aligned with the latest docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove setuptools-scm-git-archive, require setuptools-scm>=7 1434498245
1302122898 https://github.com/pydata/xarray/pull/7253#issuecomment-1302122898 https://api.github.com/repos/pydata/xarray/issues/7253 IC_kwDOAMm_X85NnNGS keewis 14808389 2022-11-03T13:33:16Z 2022-11-03T13:33:16Z MEMBER

thanks for the PR, @mwtoews! I noticed that a few hours ago (probably just after you opened this PR) the documentation of setuptools_scm was changed to recommend describe-name: $Format:%(describe:tags=true,match=*[0-9]*)$ instead of describe-name: $Format:%(describe:tags=true)$

Should we also be using that? Or would that require a development version of setuptools_scm?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove setuptools-scm-git-archive, require setuptools-scm>=7 1434498245

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);