issue_comments

Table actions

7 rows where issue = 1428748922 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Improve non-nanosecond warning · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1303772205 https://github.com/pydata/xarray/pull/7238#issuecomment-1303772205 https://api.github.com/repos/pydata/xarray/issues/7238 IC_kwDOAMm_X85Ntfwt keewis 14808389 2022-11-04T15:35:12Z 2022-11-04T15:35:12Z MEMBER

It looks like I've stumbled upon some new upstream test failures

it's not really new (the CI has been failing since about 4 days ago), but because so many tests fail we're hitting the size limit for new issues: {"resource":"Issue","code":"custom","field":"body","message":"body is too long (maximum is 65536 characters)"}

Not sure if we can do something about that in the action?

cc @andersy005

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve non-nanosecond warning 1428748922
1303356166 https://github.com/pydata/xarray/pull/7238#issuecomment-1303356166 https://api.github.com/repos/pydata/xarray/issues/7238 IC_kwDOAMm_X85Nr6MG spencerkclark 6628425 2022-11-04T12:07:19Z 2022-11-04T12:07:19Z MEMBER

It looks like I've stumbled upon some new upstream test failures related to https://github.com/pandas-dev/pandas/pull/49101.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve non-nanosecond warning 1428748922
1303303334 https://github.com/pydata/xarray/pull/7238#issuecomment-1303303334 https://api.github.com/repos/pydata/xarray/issues/7238 IC_kwDOAMm_X85NrtSm spencerkclark 6628425 2022-11-04T11:39:44Z 2022-11-04T11:39:44Z MEMBER

Nice find @mathause! That seems to work. I added a version of that function to utils. The warning from my example above now looks like: test_warning.py:5: UserWarning: Converting non-nanosecond precision datetime values to nanosecond precision. This behavior can eventually be relaxed in xarray, as it is an artifact from pandas which is now beginning to support non-nanosecond precision values. This warning is caused by passing non-nanosecond np.datetime64 or np.timedelta64 values to the DataArray or Variable constructor; it can be silenced by converting the values to nanosecond precision ahead of time. da = xr.DataArray([1], dims=["time"], coords=[times])

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve non-nanosecond warning 1428748922
1301816540 https://github.com/pydata/xarray/pull/7238#issuecomment-1301816540 https://api.github.com/repos/pydata/xarray/issues/7238 IC_kwDOAMm_X85NmCTc mathause 10194086 2022-11-03T09:09:25Z 2022-11-03T09:09:25Z MEMBER

Pandas has a find_stack_level function (https://github.com/pandas-dev/pandas/blob/0106c26529900bad0561efb9c9180f7f016365b0/pandas/util/_exceptions.py#L28). But I am not sure if this would fix the problem?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve non-nanosecond warning 1428748922
1298658702 https://github.com/pydata/xarray/pull/7238#issuecomment-1298658702 https://api.github.com/repos/pydata/xarray/issues/7238 IC_kwDOAMm_X85NZ_WO dcherian 2448579 2022-11-01T15:08:32Z 2022-11-01T15:08:32Z MEMBER

.I was kind of hoping we could avoid something like adding a _stacklevel_increment argument,

:( I don't know of any other way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve non-nanosecond warning 1428748922
1296269381 https://github.com/pydata/xarray/pull/7238#issuecomment-1296269381 https://api.github.com/repos/pydata/xarray/issues/7238 IC_kwDOAMm_X85NQ4BF hmaarrfk 90008 2022-10-30T14:10:23Z 2022-10-30T14:10:23Z CONTRIBUTOR

Hmm...I was kind of hoping we could avoid something like adding a _stacklevel_increment argument.

Right. thank you for finding that example. I was going to try to construct one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve non-nanosecond warning 1428748922
1296235033 https://github.com/pydata/xarray/pull/7238#issuecomment-1296235033 https://api.github.com/repos/pydata/xarray/issues/7238 IC_kwDOAMm_X85NQvoZ spencerkclark 6628425 2022-10-30T11:56:00Z 2022-10-30T11:56:00Z MEMBER

Hmm...I was kind of hoping we could avoid something like adding a _stacklevel_increment argument, but hardcoding the stacklevel obviously doesn't work in the case that fields are converted to variables within xarray, e.g. in the case of passing coordinates to the DataArray constructor:

```python import numpy as np import xarray as xr

times = [np.datetime64("2000-01-01", "us")] da = xr.DataArray([1], dims=["time"], coords=[times]) ```

$ python test_warning.py /Users/spencer/software/xarray/xarray/core/dataarray.py:148: UserWarning: Converting non-nanosecond precision datetime values to nanosecond precision. This behavior can eventually be relaxed in xarray, as it is an artifact from pandas which is now beginning to support non-nanosecond precision values. This warning is caused by passing non-nanosecond np.datetime64 or np.timedelta64 values to the DataArray or Variable constructor; it can be silenced by converting the values to nanosecond precision ahead of time. var = as_variable(coord, name=dim)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve non-nanosecond warning 1428748922

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);