issue_comments

Table actions

5 rows where issue = 1428549868 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • The new NON_NANOSECOND_WARNING is not very nice to end users · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1540065557 https://github.com/pydata/xarray/issues/7237#issuecomment-1540065557 https://api.github.com/repos/pydata/xarray/issues/7237 IC_kwDOAMm_X85by4kV spencerkclark 6628425 2023-05-09T12:52:54Z 2023-05-09T12:52:54Z MEMBER

For a little more discussion of this issue see #7493. As the example at the top of the issue notes, there is at least one place where non-nanosecond times can slip in (this is not intentional), but for most code pathways xarray should currently convert things automatically.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   The new NON_NANOSECOND_WARNING is not very nice to end users 1428549868
1540020315 https://github.com/pydata/xarray/issues/7237#issuecomment-1540020315 https://api.github.com/repos/pydata/xarray/issues/7237 IC_kwDOAMm_X85bythb spencerkclark 6628425 2023-05-09T12:11:24Z 2023-05-09T12:11:24Z MEMBER

Xarray will convert any non-nanosecond precision times to nanosecond precision (or an error will be raised if this is not possible). 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   The new NON_NANOSECOND_WARNING is not very nice to end users 1428549868
1539073371 https://github.com/pydata/xarray/issues/7237#issuecomment-1539073371 https://api.github.com/repos/pydata/xarray/issues/7237 IC_kwDOAMm_X85bvGVb djhoese 1828519 2023-05-08T21:23:59Z 2023-05-08T21:23:59Z CONTRIBUTOR

And with new pandas (which I understand as being the thing/library that is changing) and new xarray, what will happen? What happens between nano and non-nano times?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   The new NON_NANOSECOND_WARNING is not very nice to end users 1428549868
1538934080 https://github.com/pydata/xarray/issues/7237#issuecomment-1538934080 https://api.github.com/repos/pydata/xarray/issues/7237 IC_kwDOAMm_X85bukVA spencerkclark 6628425 2023-05-08T19:35:05Z 2023-05-08T19:35:05Z MEMBER

For the time being xarray should behave as it always has, converting any non-nanosecond precision times to nanosecond-precision before being used internally.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   The new NON_NANOSECOND_WARNING is not very nice to end users 1428549868
1538397945 https://github.com/pydata/xarray/issues/7237#issuecomment-1538397945 https://api.github.com/repos/pydata/xarray/issues/7237 IC_kwDOAMm_X85bshb5 djhoese 1828519 2023-05-08T13:53:19Z 2023-05-08T13:53:19Z CONTRIBUTOR

Sorry for dragging this issue up again, but even with the new warning message I still have some questions. Do I have to switch to nanosecond precision times or will xarray/pandas/numpy just figure it out when I combine/compare times with different precisions?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   The new NON_NANOSECOND_WARNING is not very nice to end users 1428549868

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);