issue_comments

Table actions

6 rows where issue = 1428274982 and user = 90008 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • hmaarrfk · 6 ✖

issue 1

  • Expand benchmarks for dataset insertion and creation · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1295999237 https://github.com/pydata/xarray/pull/7236#issuecomment-1295999237 https://api.github.com/repos/pydata/xarray/issues/7236 IC_kwDOAMm_X85NP2EF hmaarrfk 90008 2022-10-29T22:11:33Z 2022-10-29T22:11:33Z CONTRIBUTOR

Well now the benchmarks look like they make more sense: [ 50.00%] ··· ==================== ========== ========== ========== ========== ========== -- count -------------------- ------------------------------------------------------ strategy 0 1 10 100 1000 ==================== ========== ========== ========== ========== ========== dict_of_DataArrays 1.56±0ms 3.60±0ms 5.83±0ms 16.6±0ms 67.3±0ms dict_of_Variables 1.65±0ms 3.11±0ms 4.03±0ms 6.22±0ms 18.9±0ms dict_of_Tuples 2.42±0ms 3.11±0ms 982±0μs 5.17±0ms 17.2±0ms ==================== ========== ========== ========== ========== ==========

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expand benchmarks for dataset insertion and creation 1428274982
1295937569 https://github.com/pydata/xarray/pull/7236#issuecomment-1295937569 https://api.github.com/repos/pydata/xarray/issues/7236 IC_kwDOAMm_X85NPnAh hmaarrfk 90008 2022-10-29T18:58:35Z 2022-10-29T18:58:35Z CONTRIBUTOR

[ 50.00%] ··· ==================== ========== ========== ========== ========== ========== -- count -------------------- ------------------------------------------------------ strategy 0 1 10 100 1000 ==================== ========== ========== ========== ========== ========== dict_of_DataArrays 1.65±0ms 3.83±0ms 4.03±0ms 6.14±0ms 16.6±0ms dict_of_Variables 3.04±0ms 3.24±0ms 3.38±0ms 4.04±0ms 9.91±0ms dict_of_Tuples 2.90±0ms 3.03±0ms 3.32±0ms 3.22±0ms 3.22±0ms ==================== ========== ========== ========== ========== ==========

as you though, the numbers improve quite a bit.

I kinda want to understand why a no-op takes 1 ms! ^_^

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expand benchmarks for dataset insertion and creation 1428274982
1295937364 https://github.com/pydata/xarray/pull/7236#issuecomment-1295937364 https://api.github.com/repos/pydata/xarray/issues/7236 IC_kwDOAMm_X85NPm9U hmaarrfk 90008 2022-10-29T18:57:54Z 2022-10-29T18:57:54Z CONTRIBUTOR

What about just specifying "dims"?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expand benchmarks for dataset insertion and creation 1428274982
1295905591 https://github.com/pydata/xarray/pull/7236#issuecomment-1295905591 https://api.github.com/repos/pydata/xarray/issues/7236 IC_kwDOAMm_X85NPfM3 hmaarrfk 90008 2022-10-29T17:11:30Z 2022-10-29T17:11:30Z CONTRIBUTOR

With the right window size it looks like: [ 50.00%] ··· ==================== ========== ========== ========== ========== ========== -- count -------------------- ------------------------------------------------------ strategy 0 1 10 100 1000 ==================== ========== ========== ========== ========== ========== dict_of_DataArrays 1.32±0ms 5.87±0ms 7.58±0ms 18.7±0ms 98.6±0ms dict_of_Variables 2.70±0ms 2.91±0ms 3.01±0ms 3.91±0ms 7.04±0ms dict_of_Tuples 2.84±0ms 3.02±0ms 3.22±0ms 3.42±0ms 3.02±0ms ==================== ========== ========== ========== ========== ==========

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expand benchmarks for dataset insertion and creation 1428274982
1295852860 https://github.com/pydata/xarray/pull/7236#issuecomment-1295852860 https://api.github.com/repos/pydata/xarray/issues/7236 IC_kwDOAMm_X85NPSU8 hmaarrfk 90008 2022-10-29T14:28:25Z 2022-10-29T14:28:25Z CONTRIBUTOR

On the CI, it reports similar findings: ``` [ 67.73%] ··· ...dVariable.time_dict_of_dataarrays_to_dataset ok [ 67.73%] ··· =================== ============= existing_elements
------------------- ------------- 0 269±0.9μs
10 2.21±0.01ms 100 16.5±0.07ms 1000 153±0.9ms
=================== =============

[ 67.88%] ··· ...etAddVariable.time_dict_of_tuples_to_dataset ok [ 67.88%] ··· =================== =========== existing_elements
------------------- ----------- 0 269±0.6μs 10 289±0.4μs 100 293±1μs
1000 346±0.4μs =================== ===========

[ 68.02%] ··· ...ddVariable.time_dict_of_variables_to_dataset ok [ 68.02%] ··· =================== ============= existing_elements
------------------- ------------- 0 270±1μs
10 329±0.6μs
100 636±1μs
1000 3.70±0.01ms =================== =============

[ 68.17%] ··· ...e.DatasetAddVariable.time_merge_two_datasets ok [ 68.17%] ··· =================== ============= existing_elements
------------------- ------------- 0 104±0.5μs
10 235±0.6μs
100 1.05±0ms
1000 9.02±0.02ms =================== =============

[ 68.31%] ··· ...e.DatasetAddVariable.time_variable_insertion ok [ 68.31%] ··· =================== ============= existing_elements
------------------- ------------- 0 119±1μs
10 225±0.7μs
100 1.04±0ms
1000 9.03±0.03ms =================== ============= ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expand benchmarks for dataset insertion and creation 1428274982
1295843798 https://github.com/pydata/xarray/pull/7236#issuecomment-1295843798 https://api.github.com/repos/pydata/xarray/issues/7236 IC_kwDOAMm_X85NPQHW hmaarrfk 90008 2022-10-29T13:55:33Z 2022-10-29T13:55:33Z CONTRIBUTOR

``` $ asv run -E existing --quick --bench merge · Discovering benchmarks · Running 5 total benchmarks (1 commits * 1 environments * 5 benchmarks) [ 0.00%] ·· Benchmarking existing-py_home_mark_mambaforge_envs_mcam_dev_bin_python [ 10.00%] ··· merge.DatasetAddVariable.time_dict_of_dataarrays_to_dataset ok [ 10.00%] ··· =================== ========== existing_elements ------------------- ---------- 0 762±0μs 10 7.18±0ms 100 12.6±0ms 1000 89.1±0ms =================== ==========

[ 20.00%] ··· merge.DatasetAddVariable.time_dict_of_tuples_to_dataset ok [ 20.00%] ··· =================== ========== existing_elements ------------------- ---------- 0 889±0μs 10 2.01±0ms 100 1.34±0ms 1000 605±0μs =================== ==========

[ 30.00%] ··· merge.DatasetAddVariable.time_dict_of_variables_to_dataset ok [ 30.00%] ··· =================== ========== existing_elements ------------------- ---------- 0 2.48±0ms 10 2.06±0ms 100 2.13±0ms 1000 2.38±0ms =================== ==========

[ 40.00%] ··· merge.DatasetAddVariable.time_merge_two_datasets ok [ 40.00%] ··· =================== ========== existing_elements ------------------- ---------- 0 814±0μs 10 945±0μs 100 2.42±0ms 1000 5.23±0ms =================== ==========

[ 50.00%] ··· merge.DatasetAddVariable.time_variable_insertion ok [ 50.00%] ··· =================== ========== existing_elements ------------------- ---------- 0 1.10±0ms 10 954±0μs 100 1.88±0ms 1000 5.29±0ms =================== ========== ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Expand benchmarks for dataset insertion and creation 1428274982

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);