issue_comments

Table actions

3 rows where issue = 142676995 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Adds dask lock capability for backend writes · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
200062633 https://github.com/pydata/xarray/pull/800#issuecomment-200062633 https://api.github.com/repos/pydata/xarray/issues/800 MDEyOklzc3VlQ29tbWVudDIwMDA2MjYzMw== shoyer 1217238 2016-03-22T22:32:37Z 2016-03-22T22:32:37Z MEMBER

Thanks @pwolfram !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adds dask lock capability for backend writes 142676995
200055940 https://github.com/pydata/xarray/pull/800#issuecomment-200055940 https://api.github.com/repos/pydata/xarray/issues/800 MDEyOklzc3VlQ29tbWVudDIwMDA1NTk0MA== pwolfram 4295853 2016-03-22T22:15:51Z 2016-03-22T22:15:51Z CONTRIBUTOR

Thanks @shoyer for the review. I agree regarding this being simple enough to not require testing so this PR is probably ready to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adds dask lock capability for backend writes 142676995
199890899 https://github.com/pydata/xarray/pull/800#issuecomment-199890899 https://api.github.com/repos/pydata/xarray/issues/800 MDEyOklzc3VlQ29tbWVudDE5OTg5MDg5OQ== shoyer 1217238 2016-03-22T16:28:46Z 2016-03-22T16:28:46Z MEMBER

This is going to be hard to test, but honestly I don't think that's essential given the simplicity of this code -- the complexity is buried upstream in dask, which does have comprehensive tests.

If you do want to write a test for this, you could mock out a fake DataStore similar to what we wrote for the dask tests and turn on multi-threading. But I think that's probably overkill here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adds dask lock capability for backend writes 142676995

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);