issue_comments

Table actions

5 rows where issue = 1424215477 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • Typing with Variadic Generics in python 3.11 (PEP 646) · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1292692904 https://github.com/pydata/xarray/issues/7227#issuecomment-1292692904 https://api.github.com/repos/pydata/xarray/issues/7227 IC_kwDOAMm_X85NDO2o headtr1ck 43316012 2022-10-26T21:50:02Z 2022-10-26T21:50:02Z COLLABORATOR

I think this PEP is really more important for i.e. numpy. Something like array.sum(axis=1) is more error prone (1 instead of -1 or 2) than xarrays da.sum("time").

But yes, it is mainly for consumers.

Additionally, since xarray has its fancy broadcasting I am not sure that even with a working system we would get meaningful errors from static typecheckers. In numpy Array[Height] + Array[Width] would raise but in xarray this just works...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing with Variadic Generics in python 3.11 (PEP 646) 1424215477
1292626419 https://github.com/pydata/xarray/issues/7227#issuecomment-1292626419 https://api.github.com/repos/pydata/xarray/issues/7227 IC_kwDOAMm_X85NC-nz max-sixty 5635139 2022-10-26T20:38:25Z 2022-10-26T20:38:25Z MEMBER

IIUC, and I always feel like a newcomer on this stuff — this could be useful for xarray consumers, who could write -> DataArray[Time, Width, Height]?

But without those being generic and "programmable" — i.e. being able to describe that .mean("width") removes the axis called width, it's not that useful for xarray itself?

Is that right?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing with Variadic Generics in python 3.11 (PEP 646) 1424215477
1292252691 https://github.com/pydata/xarray/issues/7227#issuecomment-1292252691 https://api.github.com/repos/pydata/xarray/issues/7227 IC_kwDOAMm_X85NBjYT TomNicholas 35968931 2022-10-26T15:48:36Z 2022-10-26T15:53:14Z MEMBER

Well that's frustrating - I didn't see that.

They also mention that if PEP 637 hadn't been rejected there would be more use, which is ironic because we also wanted PEP 637 for indexing (like da[time=slice(5, 10)]).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing with Variadic Generics in python 3.11 (PEP 646) 1424215477
1292228024 https://github.com/pydata/xarray/issues/7227#issuecomment-1292228024 https://api.github.com/repos/pydata/xarray/issues/7227 IC_kwDOAMm_X85NBdW4 headtr1ck 43316012 2022-10-26T15:30:39Z 2022-10-26T15:30:39Z COLLABORATOR

So the only way I could see is a tuple of dimension names, and even there we will have problems because the order does not really matter for us.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing with Variadic Generics in python 3.11 (PEP 646) 1424215477
1292221168 https://github.com/pydata/xarray/issues/7227#issuecomment-1292221168 https://api.github.com/repos/pydata/xarray/issues/7227 IC_kwDOAMm_X85NBbrw headtr1ck 43316012 2022-10-26T15:25:33Z 2022-10-26T15:25:33Z COLLABORATOR

Interesting idea. But see https://peps.python.org/pep-0646/#appendix-b-shaped-types-vs-named-axes

That basically says that named axes are not supported?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Typing with Variadic Generics in python 3.11 (PEP 646) 1424215477

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);