issue_comments

Table actions

6 rows where issue = 1420242462 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • absolufy-imports - No relative imports - PEP8 · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1341625609 https://github.com/pydata/xarray/pull/7204#issuecomment-1341625609 https://api.github.com/repos/pydata/xarray/issues/7204 IC_kwDOAMm_X85P95UJ dcherian 2448579 2022-12-07T21:34:03Z 2022-12-07T21:34:03Z MEMBER

Thanks for the contribution and the patience! @Illviljan 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   absolufy-imports - No relative imports - PEP8 1420242462
1329385461 https://github.com/pydata/xarray/pull/7204#issuecomment-1329385461 https://api.github.com/repos/pydata/xarray/issues/7204 IC_kwDOAMm_X85PPM_1 dcherian 2448579 2022-11-28T16:30:00Z 2022-11-28T16:30:00Z MEMBER

Since it's a pretty 50/50 change lets discuss this at the next meeting on Dec 7.

(I bet changing the tests won't be controversial)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   absolufy-imports - No relative imports - PEP8 1420242462
1328070169 https://github.com/pydata/xarray/pull/7204#issuecomment-1328070169 https://api.github.com/repos/pydata/xarray/issues/7204 IC_kwDOAMm_X85PKL4Z Illviljan 14371165 2022-11-26T15:54:02Z 2022-11-26T15:54:02Z MEMBER

I am merging this on friday next week if no one minds. :)

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   absolufy-imports - No relative imports - PEP8 1420242462
1297256807 https://github.com/pydata/xarray/pull/7204#issuecomment-1297256807 https://api.github.com/repos/pydata/xarray/issues/7204 IC_kwDOAMm_X85NUpFn Illviljan 14371165 2022-10-31T15:24:25Z 2022-10-31T15:24:25Z MEMBER

A lot of pep8 is quite gentle with the phrasing I think: Avoid trailing whitespace anywhere. is only a recommendation. Limit all lines to a maximum of 79 characters. is also only a recommendation, we ignore this one for automation consistency.

Another nice perk with absolute paths is that you can immediately run a utils.py file and test out the functions, much faster workflow than having to do the proper import route.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   absolufy-imports - No relative imports - PEP8 1420242462
1297143372 https://github.com/pydata/xarray/pull/7204#issuecomment-1297143372 https://api.github.com/repos/pydata/xarray/issues/7204 IC_kwDOAMm_X85NUNZM keewis 14808389 2022-10-31T14:05:04Z 2022-10-31T14:05:04Z MEMBER

I'm a bit split on this.

As far as I understand it, there were two main reasons for the switch of dask / distributed: the fact that they had imports like python from .....scheduler import something (which I agree is utter madness), and because they had modules named core, so the import was a bit ambiguous to read. I don't think either apply to us: our directory structure is sufficiently flat that we get at most two levels (from .. import something), and pretty unique file names.

We're also not in conflict with PEP8: if I read that correctly, it does say they recommend absolute imports, but then it also says that explicit relative imports are fine as well (and not just in the case where a complex structure makes explicit relative imports much more readable).

This means that unlike for dask one style does not have a clear advantage over the other, and this becomes a matter of preference.

As such, my vote would be +0.5 for automated consistency, but -0.5 for absolute imports everywhere because for me explicit relative imports are actually a bit easier to read. However, I very much agree with using absolute imports of modules from the main package in tests (I think we have something like from ..core.duck_array_ops import something in one of the tests, which seems a bit weird?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   absolufy-imports - No relative imports - PEP8 1420242462
1288442663 https://github.com/pydata/xarray/pull/7204#issuecomment-1288442663 https://api.github.com/repos/pydata/xarray/issues/7204 IC_kwDOAMm_X85MzBMn max-sixty 5635139 2022-10-24T05:33:41Z 2022-10-24T05:33:41Z MEMBER

I have no particular preference on which, but +0.5 on having a standard.

Also PyLance in VSCode has (temporarily, apparently) defaulted to making all imports absolute. So perhaps that will establish a standard.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   absolufy-imports - No relative imports - PEP8 1420242462

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);