issue_comments

Table actions

9 rows where issue = 1410575877 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Lazy import dask.distributed to reduce import time of xarray · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1281117607 https://github.com/pydata/xarray/pull/7172#issuecomment-1281117607 https://api.github.com/repos/pydata/xarray/issues/7172 IC_kwDOAMm_X85MXE2n hmaarrfk 90008 2022-10-17T16:11:37Z 2022-10-17T16:11:37Z CONTRIBUTOR

Thank you all for taking the time to study, and worry about these improvements.

Now i have to figure out how my software went from 2 sec loading time to 12 ;) Totally unrelated to this. But one day I'll have benchmarking in place to monitor it :D.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy import dask.distributed to reduce import time of xarray 1410575877
1281110784 https://github.com/pydata/xarray/pull/7172#issuecomment-1281110784 https://api.github.com/repos/pydata/xarray/issues/7172 IC_kwDOAMm_X85MXDMA Illviljan 14371165 2022-10-17T16:06:48Z 2022-10-17T16:06:48Z MEMBER

Yes. very nice! It's also fun that we can see the 20% improvement in both tuna and asv. :)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy import dask.distributed to reduce import time of xarray 1410575877
1281105242 https://github.com/pydata/xarray/pull/7172#issuecomment-1281105242 https://api.github.com/repos/pydata/xarray/issues/7172 IC_kwDOAMm_X85MXB1a dcherian 2448579 2022-10-17T16:02:42Z 2022-10-17T16:02:42Z MEMBER

``` --- this PR 2022-10-17T15:43:10.2509472Z [ 65.51%] ··· import.Import.timeraw_import_xarray 818±30ms 2022-10-17T15:43:10.2510103Z [ 65.66%] ··· import.Import.timeraw_import_xarray_backends 816±3ms 2022-10-17T15:43:10.2510733Z [ 65.81%] ··· import.Import.timeraw_import_xarray_plot 826±7ms

--- main [90.51%] ··· import.Import.timeraw_import_xarray 1.02±0.03s 2022-10-17T15:49:58.9125041Z [ 90.66%] ··· import.Import.timeraw_import_xarray_backends 974±7ms 2022-10-17T15:49:58.9125536Z [ 90.81%] ··· import.Import.timeraw_import_xarray_plot 969±10ms ```

Nice improvement! Thanks @hmaarrfk 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Lazy import dask.distributed to reduce import time of xarray 1410575877
1281070734 https://github.com/pydata/xarray/pull/7172#issuecomment-1281070734 https://api.github.com/repos/pydata/xarray/issues/7172 IC_kwDOAMm_X85MW5aO dcherian 2448579 2022-10-17T15:36:36Z 2022-10-17T15:36:36Z MEMBER

The auto labeler is backfiring a bit here, haha.

Not fast enough though! 🔫 🔫 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy import dask.distributed to reduce import time of xarray 1410575877
1281065628 https://github.com/pydata/xarray/pull/7172#issuecomment-1281065628 https://api.github.com/repos/pydata/xarray/issues/7172 IC_kwDOAMm_X85MW4Kc headtr1ck 43316012 2022-10-17T15:33:17Z 2022-10-17T15:33:17Z COLLABORATOR

The auto labeler is backfiring a bit here, haha.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy import dask.distributed to reduce import time of xarray 1410575877
1280208522 https://github.com/pydata/xarray/pull/7172#issuecomment-1280208522 https://api.github.com/repos/pydata/xarray/issues/7172 IC_kwDOAMm_X85MTm6K hmaarrfk 90008 2022-10-17T02:59:41Z 2022-10-17T02:59:41Z CONTRIBUTOR

Separate issue, but do these need to be imported into xarray/init.py

At this point removing testing and tutorial would be strange and break things. Stefan in the discussion linked above speaks about the reasoning behind importing submodules in the top level namespace.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy import dask.distributed to reduce import time of xarray 1410575877
1280193902 https://github.com/pydata/xarray/pull/7172#issuecomment-1280193902 https://api.github.com/repos/pydata/xarray/issues/7172 IC_kwDOAMm_X85MTjVu max-sixty 5635139 2022-10-17T02:34:40Z 2022-10-17T02:34:40Z MEMBER

Nice!!

One would be tempted to think that this is due to xarray.testing and xarray.tutorial but those just move the imports one level down in tuna graphs.

Separate issue, but do these need to be imported into xarray/__init__.py? (I also can't see them in the third graph, but sounds like they're still there)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy import dask.distributed to reduce import time of xarray 1410575877
1280184096 https://github.com/pydata/xarray/pull/7172#issuecomment-1280184096 https://api.github.com/repos/pydata/xarray/issues/7172 IC_kwDOAMm_X85MTg8g jhamman 2443309 2022-10-17T02:22:00Z 2022-10-17T02:22:00Z MEMBER

Thanks @hmaarrfk - this looks great.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy import dask.distributed to reduce import time of xarray 1410575877
1280060008 https://github.com/pydata/xarray/pull/7172#issuecomment-1280060008 https://api.github.com/repos/pydata/xarray/issues/7172 IC_kwDOAMm_X85MTCpo headtr1ck 43316012 2022-10-16T21:20:57Z 2022-10-16T21:20:57Z COLLABORATOR 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy import dask.distributed to reduce import time of xarray 1410575877

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);