issue_comments

Table actions

5 rows where issue = 1410336255 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Error on xarray warnings in tests? · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1282128315 https://github.com/pydata/xarray/issues/7164#issuecomment-1282128315 https://api.github.com/repos/pydata/xarray/issues/7164 IC_kwDOAMm_X85Ma7m7 mathause 10194086 2022-10-18T09:51:20Z 2022-10-18T09:51:20Z MEMBER

Yes I mean the external ones. I agree that it is a good idea to disallow internal warnings (sometimes PRs introduce them without realizing...). And of course I also agree that we should act when then deprecation warnings are being thrown and not when the stuff is actually removed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error on xarray warnings in tests? 1410336255
1281541463 https://github.com/pydata/xarray/issues/7164#issuecomment-1281541463 https://api.github.com/repos/pydata/xarray/issues/7164 IC_kwDOAMm_X85MYsVX max-sixty 5635139 2022-10-17T21:53:55Z 2022-10-17T21:53:55Z MEMBER

I am a bit skeptical - we test a large range of versions and the kinds of warnings we get can be quite different. I fear that we get too many false positives and end up wrapping everything with filterwarnings("ignore").

Yes, very fair.

Though to confirm — this is a concern for the "Warnings from the min-versions test", rather than warnings that xarray issues? Or for both?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error on xarray warnings in tests? 1410336255
1281229222 https://github.com/pydata/xarray/issues/7164#issuecomment-1281229222 https://api.github.com/repos/pydata/xarray/issues/7164 IC_kwDOAMm_X85MXgGm mathause 10194086 2022-10-17T17:42:05Z 2022-10-17T17:42:05Z MEMBER

I am a bit skeptical - we test a large range of versions and the kinds of warnings we get can be quite different. I fear that we get too many false positives and end up wrapping everything with filterwarnings("ignore").

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error on xarray warnings in tests? 1410336255
1280043979 https://github.com/pydata/xarray/issues/7164#issuecomment-1280043979 https://api.github.com/repos/pydata/xarray/issues/7164 IC_kwDOAMm_X85MS-vL max-sixty 5635139 2022-10-16T19:54:28Z 2022-10-16T19:54:28Z MEMBER

There is still the problem that we support several outdated backends that will raise warnings, like pydap the outdated Version thingy. This will also happen in the min-deps builds.

Yes, good point, and I should have added above — it's still possible to ignore warnings at the test site explicitly (@pytest.mark.filterwarnings("ignore:foo"). So it's good, but also a chore, to mark each instance of those...

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error on xarray warnings in tests? 1410336255
1280005565 https://github.com/pydata/xarray/issues/7164#issuecomment-1280005565 https://api.github.com/repos/pydata/xarray/issues/7164 IC_kwDOAMm_X85MS1W9 headtr1ck 43316012 2022-10-16T16:40:27Z 2022-10-16T16:40:27Z COLLABORATOR

There is still the problem that we support several outdated backends that will raise warnings, like pydap the outdated Version thingy. This will also happen in the min-deps builds.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Error on xarray warnings in tests? 1410336255

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);