issue_comments

Table actions

7 rows where issue = 1409811164 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • copy of custom index does not align with original · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1483378761 https://github.com/pydata/xarray/issues/7162#issuecomment-1483378761 https://api.github.com/repos/pydata/xarray/issues/7162 IC_kwDOAMm_X85YapBJ dcherian 2448579 2023-03-24T20:37:12Z 2023-03-24T20:37:12Z MEMBER

Thanks @scottyhq 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy of custom index does not align with original 1409811164
1483302077 https://github.com/pydata/xarray/issues/7162#issuecomment-1483302077 https://api.github.com/repos/pydata/xarray/issues/7162 IC_kwDOAMm_X85YaWS9 scottyhq 3924836 2023-03-24T19:22:56Z 2023-03-24T19:23:46Z MEMBER

Reviving this exploration with xarray : 2023.3.0 and I'm no longer seeing the traceback linked above, so I think this can be closed

Original traceback from xr.align(copy, newds), which now succeeds: ``pytbFile ~/mambaforge/envs/xarray-release/lib/python3.10/site-packages/xarray/core/indexes.py:490, in PandasIndex.equals(self, other) 488 if not isinstance(other, PandasIndex): 489 return False --> 490 return self.index.equals(other.index) and self.dim == other.dim

AttributeError: 'PandasIndex' object has no attribute 'index' ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy of custom index does not align with original 1409811164
1291135046 https://github.com/pydata/xarray/issues/7162#issuecomment-1291135046 https://api.github.com/repos/pydata/xarray/issues/7162 IC_kwDOAMm_X85M9ShG headtr1ck 43316012 2022-10-25T20:58:22Z 2022-10-25T20:58:22Z COLLABORATOR

Could you create a MVCE without a custom index that I can use for debugging?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy of custom index does not align with original 1409811164
1282016895 https://github.com/pydata/xarray/issues/7162#issuecomment-1282016895 https://api.github.com/repos/pydata/xarray/issues/7162 IC_kwDOAMm_X85MagZ_ benbovy 4160723 2022-10-18T08:35:29Z 2022-10-18T08:49:47Z MEMBER

Indexes.copy_indexes might also require some update that includes the memo argument. But not sure if that will solve the issue here.

That's a possible cause. Alignment may fail early because .xindexes returns different mappings of coordinates vs. index objects. It's worth checking if after copying the dataset, copy.xindexes returns the same CRSIndex object for its "x", "y" and "spatial_ref" coordinates.

EDIT: checking copy.xindexes.group_by_index() is more convenient.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy of custom index does not align with original 1409811164
1282024919 https://github.com/pydata/xarray/issues/7162#issuecomment-1282024919 https://api.github.com/repos/pydata/xarray/issues/7162 IC_kwDOAMm_X85MaiXX benbovy 4160723 2022-10-18T08:41:08Z 2022-10-18T08:41:08Z MEMBER

The refactored alignment logic could be improved (cf. #7002). The error raised in the method below is not very helpful.

https://github.com/pydata/xarray/blob/ab726c536464fbf4d8878041f950d2b0ae09b862/xarray/core/alignment.py#L294-L333

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy of custom index does not align with original 1409811164
1279734637 https://github.com/pydata/xarray/issues/7162#issuecomment-1279734637 https://api.github.com/repos/pydata/xarray/issues/7162 IC_kwDOAMm_X85MRzNt headtr1ck 43316012 2022-10-15T12:22:04Z 2022-10-15T12:22:04Z COLLABORATOR

Now that I think about it, Indexes.copy_indexes might also require some update that includes the memo argument. But not sure if that will solve the issue here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy of custom index does not align with original 1409811164
1279464943 https://github.com/pydata/xarray/issues/7162#issuecomment-1279464943 https://api.github.com/repos/pydata/xarray/issues/7162 IC_kwDOAMm_X85MQxXv headtr1ck 43316012 2022-10-14T21:05:36Z 2022-10-14T21:05:36Z COLLABORATOR

I don't think there is anything wrong with the deep copy implementation. Only before it was not deep copying the indexes and now it is. Can you check if index1.equals(index2) works if they are created the same?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   copy of custom index does not align with original 1409811164

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);