issue_comments

Table actions

8 rows where issue = 1404926762 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • nightly failure with h5netcdf indexing · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1276248158 https://github.com/pydata/xarray/issues/7154#issuecomment-1276248158 https://api.github.com/repos/pydata/xarray/issues/7154 IC_kwDOAMm_X85MEgBe dcherian 2448579 2022-10-12T14:11:04Z 2022-10-12T14:11:04Z MEMBER

Thanks for the quick fix @kmuehlbauer !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   nightly failure with h5netcdf indexing 1404926762
1276206626 https://github.com/pydata/xarray/issues/7154#issuecomment-1276206626 https://api.github.com/repos/pydata/xarray/issues/7154 IC_kwDOAMm_X85MEV4i kmuehlbauer 5821660 2022-10-12T13:51:16Z 2022-10-12T13:51:16Z MEMBER

@dcherian As assumed the source was a regression in __getitem__-function over at h5netcdf. A patch is already merged. I've added a CI run against xarray github main to be on the safe side now and in future. Thanks for your help. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   nightly failure with h5netcdf indexing 1404926762
1275081323 https://github.com/pydata/xarray/issues/7154#issuecomment-1275081323 https://api.github.com/repos/pydata/xarray/issues/7154 IC_kwDOAMm_X85MADJr kmuehlbauer 5821660 2022-10-11T18:05:34Z 2022-10-11T18:05:34Z MEMBER

Thanks a lot @dcherian, much appreciated. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   nightly failure with h5netcdf indexing 1404926762
1275067046 https://github.com/pydata/xarray/issues/7154#issuecomment-1275067046 https://api.github.com/repos/pydata/xarray/issues/7154 IC_kwDOAMm_X85L__qm dcherian 2448579 2022-10-11T17:54:27Z 2022-10-11T17:55:03Z MEMBER

Thanks! This seems to work (see https://docs.pytest.org/en/7.1.x/how-to/usage.html#specifying-which-tests-to-run).

```

pytest -k "H5NetCDF" ==================================================================================================================================================== test session starts ===================================================================================================================================================== platform darwin -- Python 3.10.6, pytest-7.1.3, pluggy-1.0.0 rootdir: /Users/dcherian/work/python/xarray, configfile: setup.cfg, testpaths: xarray/tests, properties plugins: xdist-2.5.0, forked-1.4.0, env-0.6.2, hypothesis-6.56.1, cov-4.0.0 collected 15998 items / 15723 deselected / 1 skipped / 275 selected

xarray/tests/test_backends.py .......................X.......x.......................................ss...................................X.......x.......................................ss...................................X.......x.......................................ss.............................. [ 99%] xarray/tests/test_distributed.py .. [100%]

====================================================================================================================================================== warnings summary ====================================================================================================================================================== xarray/tests/test_backends.py::TestH5NetCDFData::test_zero_dimensional_variable /Users/dcherian/mambaforge/envs/xarray-release/lib/python3.10/site-packages/cfgrib/xarray_plugin.py:11: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead. if LooseVersion(xr.version) <= "0.17.0":

xarray/tests/test_backends.py::TestH5NetCDFData::test_zero_dimensional_variable /Users/dcherian/mambaforge/envs/xarray-release/lib/python3.10/site-packages/setuptools/_distutils/version.py:346: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead. other = LooseVersion(other)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html =============================================================================================================== 263 passed, 7 skipped, 15723 deselected, 3 xfailed, 3 xpassed, 2 warnings in 86.98s (0:01:26) ================================================================================================================ /Users/dcherian/mambaforge/envs/xarray-release/lib/python3.10/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 4 leaked semaphore objects to clean up at shutdown ```

And I do something similar in flox with the groupby tests. It works really well!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   nightly failure with h5netcdf indexing 1404926762
1275057560 https://github.com/pydata/xarray/issues/7154#issuecomment-1275057560 https://api.github.com/repos/pydata/xarray/issues/7154 IC_kwDOAMm_X85L_9WY kmuehlbauer 5821660 2022-10-11T17:45:24Z 2022-10-11T17:45:24Z MEMBER

I'll add two runs two h5netcdf CI, which check xarray h5netcdf related tests for latest release and latest commit to get an early warning if something breaks xarray.

What would be the correct pytest incantation to run all h5netcdf related tests? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   nightly failure with h5netcdf indexing 1404926762
1275052017 https://github.com/pydata/xarray/issues/7154#issuecomment-1275052017 https://api.github.com/repos/pydata/xarray/issues/7154 IC_kwDOAMm_X85L_7_x dcherian 2448579 2022-10-11T17:40:04Z 2022-10-11T17:40:04Z MEMBER

our github action updates any existing open "nightly test failed" issue and we forgot to close the last one...

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   nightly failure with h5netcdf indexing 1404926762
1275046093 https://github.com/pydata/xarray/issues/7154#issuecomment-1275046093 https://api.github.com/repos/pydata/xarray/issues/7154 IC_kwDOAMm_X85L_6jN kmuehlbauer 5821660 2022-10-11T17:33:59Z 2022-10-11T17:33:59Z MEMBER

OMG, that's already failing for 12 days. How could we miss this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   nightly failure with h5netcdf indexing 1404926762
1274976865 https://github.com/pydata/xarray/issues/7154#issuecomment-1274976865 https://api.github.com/repos/pydata/xarray/issues/7154 IC_kwDOAMm_X85L_pph kmuehlbauer 5821660 2022-10-11T16:37:13Z 2022-10-11T16:37:13Z MEMBER

Thanks @dcherian for the ping. Most likely due to upstream change (recent merge) in h5netcdf. Investigating this the next days.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   nightly failure with h5netcdf indexing 1404926762

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);