home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

13 rows where issue = 139956689 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 8

  • pwolfram 3
  • shoyer 2
  • jhamman 2
  • spencerahill 2
  • rabernat 1
  • brews 1
  • max-sixty 1
  • milenaveneziani 1

author_association 3

  • CONTRIBUTOR 6
  • MEMBER 6
  • NONE 1

issue 1

  • Time limitation (between years 1678 and 2262) restrictive to climate community · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
388649930 https://github.com/pydata/xarray/issues/789#issuecomment-388649930 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDM4ODY0OTkzMA== spencerahill 6200806 2018-05-13T19:24:18Z 2018-05-13T19:24:18Z CONTRIBUTOR

Closed by #1252 ?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
222178311 https://github.com/pydata/xarray/issues/789#issuecomment-222178311 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDIyMjE3ODMxMQ== spencerahill 6200806 2016-05-27T15:32:54Z 2016-05-27T15:32:54Z CONTRIBUTOR

Pandas has created a poll on their mailing list about this issue...I encourage everybody to speak up there: https://groups.google.com/forum/#!topic/pydata/kk04maBGw1U

(Will blast this to xarray mailing list also)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
219928912 https://github.com/pydata/xarray/issues/789#issuecomment-219928912 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDIxOTkyODkxMg== jhamman 2443309 2016-05-18T05:29:20Z 2016-05-18T05:29:20Z MEMBER

@brews - I think this issue (https://github.com/pydata/pandas/issues/7307) covers the main gist of what we're talking about here.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
219923130 https://github.com/pydata/xarray/issues/789#issuecomment-219923130 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDIxOTkyMzEzMA== brews 2049051 2016-05-18T04:37:03Z 2016-05-18T04:37:03Z CONTRIBUTOR

Just curious, has anyone tried to open an issue in pandas for this?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
195031692 https://github.com/pydata/xarray/issues/789#issuecomment-195031692 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDE5NTAzMTY5Mg== jhamman 2443309 2016-03-10T20:23:26Z 2016-03-10T20:23:26Z MEMBER

This might make slightly more sense in a related but distinct project to xarray.

@shoyer - are you thinking xarray would fall back to a CustomDatetimeIndex for non-standard calendars?

I actually don't think it would be all that hard to do this. @jswhit's netcdftime module is at least a good starting point. There's a lot to build on in netcdftime and pandas.tseries.index. I'd actually say this should be targeted at Pandas (probably as a side project) rather than xarray. Ultimately, it would be nice to be able to move timeseries back and forth without any hassle.

I'd be happy to help pull this together, although, I won't be able to make significant contributions until the summer. Is anyone chomping at the bit to work on something like this?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
194988376 https://github.com/pydata/xarray/issues/789#issuecomment-194988376 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDE5NDk4ODM3Ng== shoyer 1217238 2016-03-10T18:22:38Z 2016-03-10T19:46:33Z MEMBER

Well, the good news is that non-standard calendars like 365 are actually a bit easier than the Gregorian calendar, at least if you were starting from scratch. As much as I love pushing fixes upstream, the most sane approach is to probably write a CustomDatetimeIndex class from scratch and start checking off boxes on datetime functionality: - [ ] support for datetime indexing functionality (the pandas get_indexer, get_loc and slice_indexer methods) - [ ] support for pulling out datetime components (e.g., year or hour) - [ ] support for resample (I'm not exactly sure what the right API is here)

This might make slightly more sense in a related but distinct project to xarray.

NumPy and pandas developers will listen sympathetically, but ultimately nobody is going to work on this unless there is funding or they need it for their own work -- that's just how open source works. Fixing the underlying technology so these problems can be solved the "right" way is on the roadmap, but only in a vague, we'll get to it eventually kind of way.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
195010525 https://github.com/pydata/xarray/issues/789#issuecomment-195010525 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDE5NTAxMDUyNQ== max-sixty 5635139 2016-03-10T19:29:40Z 2016-03-10T19:29:40Z MEMBER

Periods can go back much further, depending on the precision you need:

python In [26]: pd.Period('1000', freq='D') Out[26]: Period('1000-01-01', 'D')

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
194976812 https://github.com/pydata/xarray/issues/789#issuecomment-194976812 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDE5NDk3NjgxMg== rabernat 1197350 2016-03-10T17:56:27Z 2016-03-10T17:56:27Z MEMBER

:+1: I hit this problem months back when analyzing CESM runs.

It seems silly that the adoption of xarray by the climate modeling community should rest on these highly technical issues. But that seems to be the reality. The challenge is to raise the profile of these issues within the numpy and pandas communities such that they become a high priority. Even better would be dedicated developer time (e.g. from someone at UNIDATA) to implement fixes.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
194973785 https://github.com/pydata/xarray/issues/789#issuecomment-194973785 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDE5NDk3Mzc4NQ== pwolfram 4295853 2016-03-10T17:47:10Z 2016-03-10T17:47:10Z CONTRIBUTOR

Thank you very much @shoyer for your very fast reply. If we fixed the issue in pandas (e.g., your 1) would that be sufficient to resolve the issue or do we also need to enhance datetime64 also (e.g., your 2)? What is your recommendation on the best way to proceed and is it even reasonable to do so?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
194972364 https://github.com/pydata/xarray/issues/789#issuecomment-194972364 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDE5NDk3MjM2NA== milenaveneziani 8237579 2016-03-10T17:43:07Z 2016-03-10T17:43:07Z NONE

Thank you, @pwolfram, for bringing this up. I just wanted to add that this limitation is important for analyzing so-called fixed-conditions climate model experiments, in which the model is run with fixed greenhouse gases conditions for a particular year (say, fixed levels of CO2 concentration representative of levels for the year 1850, for example). In these cases, time is simply measured with respect to start of simulation (year 0, or year 1) and each year is a no-leap year of 365 days.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
194971898 https://github.com/pydata/xarray/issues/789#issuecomment-194971898 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDE5NDk3MTg5OA== shoyer 1217238 2016-03-10T17:41:27Z 2016-03-10T17:41:27Z MEMBER

There are two issues here: 1. Support for years outside 1678-2262 -- blocked by pandas standardizing on nanosecond precision. 2. Support for custom calendars -- blocked by limitations of numpy's datetime64.

Unfortunately, I don't see easy fixes to either of these, though if I had to guess, adding support for other datetime precisions (perhaps only sub-second resolution) to pandas would be easier than fixing up NumPy's datetime64 itself (which is already pretty hacky).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
194966713 https://github.com/pydata/xarray/issues/789#issuecomment-194966713 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDE5NDk2NjcxMw== pwolfram 4295853 2016-03-10T17:27:01Z 2016-03-10T17:27:01Z CONTRIBUTOR

See also https://github.com/pydata/xarray/issues/531 (cc @jsbj, @darothen, @jhamman); https://github.com/pydata/xarray/issues/521 (cc @rabernat, @jhamman)

It appears this is an issue with the numpy datetime64 API (https://github.com/numpy/numpy/issues/6207).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689
194964987 https://github.com/pydata/xarray/issues/789#issuecomment-194964987 https://api.github.com/repos/pydata/xarray/issues/789 MDEyOklzc3VlQ29tbWVudDE5NDk2NDk4Nw== pwolfram 4295853 2016-03-10T17:22:11Z 2016-03-10T17:22:11Z CONTRIBUTOR

@jhamman and @shoyer, do you know if more general support for times will be provided?

I would say this is a potential roadblock inhibiting easy adoption of this library within the climate community. For example, this is creating problems when we setup and analyze climate models (cc @akturner, @douglasjacobsen, @milenaveneziani). There are obvious work arounds, but they are hacks, e.g., I just add 1700 or some arbitrary year within my wrapper to MPAS at https://github.com/pwolfram/mpas_xarray_wrapper. However, this does not appear to be a viable long-term solution.

Does anyone have some advice on how to better deal with this problem?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Time limitation (between years 1678 and 2262) restrictive to climate community 139956689

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 561.058ms · About: xarray-datasette