issue_comments

Table actions

5 rows where issue = 1388372090 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Align typing of dimension inputs · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1277983783 https://github.com/pydata/xarray/issues/7094#issuecomment-1277983783 https://api.github.com/repos/pydata/xarray/issues/7094 IC_kwDOAMm_X85MLHwn max-sixty 5635139 2022-10-13T18:02:16Z 2022-10-13T18:02:16Z MEMBER

Ah excellent, thanks @headtr1ck 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align typing of dimension inputs 1388372090
1277298306 https://github.com/pydata/xarray/issues/7094#issuecomment-1277298306 https://api.github.com/repos/pydata/xarray/issues/7094 IC_kwDOAMm_X85MIgaC headtr1ck 43316012 2022-10-13T09:19:11Z 2022-10-13T09:20:06Z COLLABORATOR

We can build a list if we need a len? Or IIRC there is a Sized type — a Set but not an Iterable.

We already do that.

We have the following solutions:

  1. We allow any Iterable and it is up to the user to ensure correct ordering (mypy does not complain when a set is supplied)
  2. We require a Sequence which ensures ordering (user cannot supply a np.ndarray e.g.)
  3. We make the type more complicated to support ArrayLike as well.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align typing of dimension inputs 1388372090
1272606108 https://github.com/pydata/xarray/issues/7094#issuecomment-1272606108 https://api.github.com/repos/pydata/xarray/issues/7094 IC_kwDOAMm_X85L2m2c max-sixty 5635139 2022-10-09T18:51:52Z 2022-10-09T18:51:52Z MEMBER

Usually we do not use len(input) or x in input though. Maybe reversible container or something else exists?

We can build a list if we need a len? Or IIRC there is a Sized type — a Set but not an Iterable.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align typing of dimension inputs 1388372090
1272523338 https://github.com/pydata/xarray/issues/7094#issuecomment-1272523338 https://api.github.com/repos/pydata/xarray/issues/7094 IC_kwDOAMm_X85L2SpK headtr1ck 43316012 2022-10-09T11:40:57Z 2022-10-09T11:45:24Z COLLABORATOR

Yes, sequence sounds right if the order matters. Usually we do not use len(input) or x in input though. Maybe reversible container or something else exists?

A bit unfortunate that np.ndarray is not a sequence though, but I think using them for dimensions of not a very common use case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align typing of dimension inputs 1388372090
1269679657 https://github.com/pydata/xarray/issues/7094#issuecomment-1269679657 https://api.github.com/repos/pydata/xarray/issues/7094 IC_kwDOAMm_X85LrcYp derhintze 25172489 2022-10-06T09:30:30Z 2022-10-06T09:30:44Z NONE

Iterables (implement __iter__) not only aren't ordered, but also neither have a length (implement __len__ nor allow for membership tests (implement __contains__). So in these cases one needs to use Sequences, too; in addition to cases where order matters.

See https://docs.python.org/3.9/library/collections.abc.html#collections-abstract-base-classes 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Align typing of dimension inputs 1388372090

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);