issue_comments

Table actions

5 rows where issue = 1368027148 and user = 60435591 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • veenstrajelmer · 5 ✖

issue 1

  • xarray imshow and pcolormesh behave badly when the array does not contain values larger the BoundaryNorm vmax · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1464031031 https://github.com/pydata/xarray/issues/7014#issuecomment-1464031031 https://api.github.com/repos/pydata/xarray/issues/7014 IC_kwDOAMm_X85XQ1c3 veenstrajelmer 60435591 2023-03-10T16:07:26Z 2023-03-10T16:07:43Z CONTRIBUTOR

Thanks to @jklymak, there was an update in PR I created (https://github.com/pydata/xarray/pull/7553). @ghiggi with the code from this PR, your code shows identical plots (except for the first one, but that should be the case). Hopefully the PR can be merged somewhere soon.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray imshow and pcolormesh behave badly when the array does not contain values larger the BoundaryNorm vmax 1368027148
1448311848 https://github.com/pydata/xarray/issues/7014#issuecomment-1448311848 https://api.github.com/repos/pydata/xarray/issues/7014 IC_kwDOAMm_X85WU3wo veenstrajelmer 60435591 2023-02-28T14:46:32Z 2023-02-28T14:46:32Z CONTRIBUTOR

@ghiggi: If I understand it correctly, your issue/examplecode covers multiple issues. Since one subissue might be using norm instead levels, I would recommend trimming down your example code do only show the remaining vmax issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray imshow and pcolormesh behave badly when the array does not contain values larger the BoundaryNorm vmax 1368027148
1446128457 https://github.com/pydata/xarray/issues/7014#issuecomment-1446128457 https://api.github.com/repos/pydata/xarray/issues/7014 IC_kwDOAMm_X85WMitJ veenstrajelmer 60435591 2023-02-27T11:06:40Z 2023-02-27T11:18:17Z CONTRIBUTOR

The related issues https://github.com/pydata/xarray/issues/4061 and https://github.com/Deltares/xugrid/issues/49 are fixed by supplying levels=levels instead of norm=norm to ds.plot(), as suggested by https://github.com/pydata/xarray/pull/7553#discussion_r1117264787. However, I cannot judge if this also fixes the example from this issue, since the plots still all look different. However, commenting #da1.data[da1.data>=norm.vmax] = norm.vmax - 1 solves most of the differences. @ghiggi: could you check if this suggestion solves your issue indeed?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray imshow and pcolormesh behave badly when the array does not contain values larger the BoundaryNorm vmax 1368027148
1441530710 https://github.com/pydata/xarray/issues/7014#issuecomment-1441530710 https://api.github.com/repos/pydata/xarray/issues/7014 IC_kwDOAMm_X85V7ANW veenstrajelmer 60435591 2023-02-23T10:36:36Z 2023-02-23T15:55:21Z CONTRIBUTOR

I just combined @Huite's suggestion with splitting the if-statement. This works for both solving the issue and keeping the testcases in test_plot.py green. if levels is not None: cmap, newnorm = _build_discrete_cmap(cmap, levels, extend, filled) norm = newnorm if norm is None else norm if isinstance(norm, mpl.colors.BoundaryNorm): cmap, norm = _build_discrete_cmap(cmap, levels, extend, filled) This could replace this code: https://github.com/pydata/xarray/blob/1de881e5f5d4d7697403f9ab7686849ab02953bd/xarray/plot/utils.py#L307

However, a bit up in the code there is a if isinstance(norm, mpl.colors.BoundaryNorm) statement, which I guess could be combined. https://github.com/pydata/xarray/blob/1de881e5f5d4d7697403f9ab7686849ab02953bd/xarray/plot/utils.py#L277 if isinstance(norm, mpl.colors.BoundaryNorm): levels = norm.boundaries

I think it is a potential solution nevertheless, but some help is appreciated with the last steps. Also since the case of @ghiggi seems not to be solved with this fix. It does solve https://github.com/pydata/xarray/issues/4061 though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray imshow and pcolormesh behave badly when the array does not contain values larger the BoundaryNorm vmax 1368027148
1410362988 https://github.com/pydata/xarray/issues/7014#issuecomment-1410362988 https://api.github.com/repos/pydata/xarray/issues/7014 IC_kwDOAMm_X85UEG5s veenstrajelmer 60435591 2023-01-31T13:32:44Z 2023-01-31T13:32:44Z CONTRIBUTOR

Is there any update on this issue? I have been running into the same problem recently and am happy to see that this issue was already recognized by others.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xarray imshow and pcolormesh behave badly when the array does not contain values larger the BoundaryNorm vmax 1368027148

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);