issue_comments

Table actions

5 rows where issue = 1362895131 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • attrs are now views, not copies · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1237982464 https://github.com/pydata/xarray/issues/6996#issuecomment-1237982464 https://api.github.com/repos/pydata/xarray/issues/6996 IC_kwDOAMm_X85Jyh0A fmaussion 10050469 2022-09-06T10:45:36Z 2022-09-06T10:45:36Z MEMBER

Sorry false alarm the bug that caused salem tests to fail is indeed solved by https://github.com/pydata/xarray/pull/6857

Sorry for the noise.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   attrs are now views, not copies 1362895131
1237920815 https://github.com/pydata/xarray/issues/6996#issuecomment-1237920815 https://api.github.com/repos/pydata/xarray/issues/6996 IC_kwDOAMm_X85JySwv fmaussion 10050469 2022-09-06T09:46:49Z 2022-09-06T09:46:49Z MEMBER

Is there an older version where it returned copies?

Yes, tests started to fail on salem which I haven't maintained in quite a long time. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   attrs are now views, not copies 1362895131
1237919605 https://github.com/pydata/xarray/issues/6996#issuecomment-1237919605 https://api.github.com/repos/pydata/xarray/issues/6996 IC_kwDOAMm_X85JySd1 benbovy 4160723 2022-09-06T09:45:40Z 2022-09-06T09:45:40Z MEMBER

This happens with previous versions too (e.g., 0.21.0). Is there an older version where it returned copies?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   attrs are now views, not copies 1362895131
1237918086 https://github.com/pydata/xarray/issues/6996#issuecomment-1237918086 https://api.github.com/repos/pydata/xarray/issues/6996 IC_kwDOAMm_X85JySGG fmaussion 10050469 2022-09-06T09:44:20Z 2022-09-06T09:44:20Z MEMBER

Yes sorry I also tested on main and this still occurs. Tagging this as bug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   attrs are now views, not copies 1362895131
1237882216 https://github.com/pydata/xarray/issues/6996#issuecomment-1237882216 https://api.github.com/repos/pydata/xarray/issues/6996 IC_kwDOAMm_X85JyJVo benbovy 4160723 2022-09-06T09:14:46Z 2022-09-06T09:14:46Z MEMBER

I thought #6857 would have fixed it but apparently not.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   attrs are now views, not copies 1362895131

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);