issue_comments

Table actions

5 rows where issue = 1357296406 and user = 4160723 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • benbovy · 5 ✖

issue 1

  • Add set_xindex and drop_indexes methods · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1259349072 https://github.com/pydata/xarray/pull/6971#issuecomment-1259349072 https://api.github.com/repos/pydata/xarray/issues/6971 IC_kwDOAMm_X85LECRQ benbovy 4160723 2022-09-27T11:14:07Z 2022-09-27T11:14:07Z MEMBER

In the last commit I added the xarray.indexes namespace from which we can import Index, PandasIndex and PandasMultiIndex.

Thanks everyone for the feedback and review!

I think this is ready to merge, if we agree to address the coord_names typing issue in another PR?

 
{
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add set_xindex and drop_indexes methods 1357296406
1246569430 https://github.com/pydata/xarray/pull/6971#issuecomment-1246569430 https://api.github.com/repos/pydata/xarray/issues/6971 IC_kwDOAMm_X85KTSPW benbovy 4160723 2022-09-14T10:33:17Z 2022-09-14T10:33:17Z MEMBER

Have you thought about whether we might want to expose a separate public xarray.indexes namespace?

Yes I've been thinking about it and I agree I find it cleaner than exposing all of this in Xarray's main namespace. There's a few (minor) cons, though:

  • I think the indexes.py and indexing.py modules and their content are well located in core
  • We could create a xarray/indexes/__init__.py and import there a few "public" classes from core, but is it worth it? I'm not sure if the number of Xarray built-in indexes will grow much beyond PandasIndex and PandasMultiIndex. Perhaps it's preferable not?
  • Things like CFTimeIndex are already imported in Xarray's main namespace
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add set_xindex and drop_indexes methods 1357296406
1239114118 https://github.com/pydata/xarray/pull/6971#issuecomment-1239114118 https://api.github.com/repos/pydata/xarray/issues/6971 IC_kwDOAMm_X85J22GG benbovy 4160723 2022-09-07T09:03:46Z 2022-09-07T09:03:46Z MEMBER

Should we make the index_cls argument of set_xindex optional?

I ended up doing it. It is convenient for setting a pandas index for a non-dimension coordinate, which is currently not possible to do with set_index(). For unindexed dimension coordinates (e.g., now possible after renaming coordinates or dimensions), I find the syntax set_index(x="x") a bit weird compared to set_xindex("x").

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add set_xindex and drop_indexes methods 1357296406
1232960157 https://github.com/pydata/xarray/pull/6971#issuecomment-1232960157 https://api.github.com/repos/pydata/xarray/issues/6971 IC_kwDOAMm_X85JfXqd benbovy 4160723 2022-08-31T13:45:26Z 2022-08-31T13:45:26Z MEMBER

BTW, viewing pull-request doc builds on RTD seems broken? Clicking on the "Details" link of the corresponding check leads to a 404.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add set_xindex and drop_indexes methods 1357296406
1232946098 https://github.com/pydata/xarray/pull/6971#issuecomment-1232946098 https://api.github.com/repos/pydata/xarray/issues/6971 IC_kwDOAMm_X85JfUOy benbovy 4160723 2022-08-31T13:33:42Z 2022-08-31T13:34:36Z MEMBER

Also, since .drop_indexes is new API I didn't feel the need to implement the old behavior regarding pandas multi-indexes (restored in #6592 and #6798 but deprecated anyway). @dcherian what do you think?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add set_xindex and drop_indexes methods 1357296406

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);