issue_comments

Table actions

2 rows where issue = 1355807694 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • empty attributes silently change · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1258641481 https://github.com/pydata/xarray/issues/6970#issuecomment-1258641481 https://api.github.com/repos/pydata/xarray/issues/6970 IC_kwDOAMm_X85LBVhJ headtr1ck 43316012 2022-09-26T21:15:58Z 2022-09-26T21:16:10Z COLLABORATOR

It is not an easy fix since we do not simply want to return None, and returning an empty dict in this case without overwriting the internal one would break things like da.attrs.update(some_dict). We would have to replace the internal _attrs already in the __init__, but not sure what else that would break.

Maybe the solution from @dcherian is the best for now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   empty attributes silently change 1355807694
1244149076 https://github.com/pydata/xarray/issues/6970#issuecomment-1244149076 https://api.github.com/repos/pydata/xarray/issues/6970 IC_kwDOAMm_X85KKDVU dcherian 2448579 2022-09-12T18:43:53Z 2022-09-12T18:43:53Z MEMBER

A less invasive change would be to pass self._attrs or {} here: https://github.com/pydata/xarray/blob/b018442c8dfa3e71ec35e294de69e2011949afec/xarray/core/dataset.py#L746-L751

(and similarly in all the other tokenize functions)

but lets see what @crusaderky thinks.

These are strictly different, but the difference should not matter for the user.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   empty attributes silently change 1355807694

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);