issue_comments

Table actions

5 rows where issue = 1353466624 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Type errors in `mypy` GitHub Action · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1277287183 https://github.com/pydata/xarray/issues/6962#issuecomment-1277287183 https://api.github.com/repos/pydata/xarray/issues/6962 IC_kwDOAMm_X85MIdsP headtr1ck 43316012 2022-10-13T09:09:59Z 2022-10-13T09:09:59Z COLLABORATOR

I think we could just add a n additional mypy 3.8 workflow by using the arg --python-version 3.8

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type errors in `mypy` GitHub Action 1353466624
1233790950 https://github.com/pydata/xarray/issues/6962#issuecomment-1233790950 https://api.github.com/repos/pydata/xarray/issues/6962 IC_kwDOAMm_X85Jiifm headtr1ck 43316012 2022-09-01T06:13:29Z 2022-09-01T06:13:29Z COLLABORATOR

Strangely it seems to happen only as part of a Union definition. Also we use tuple and dict all over the place and mypy does not complain anywhere else.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type errors in `mypy` GitHub Action 1353466624
1233735651 https://github.com/pydata/xarray/issues/6962#issuecomment-1233735651 https://api.github.com/repos/pydata/xarray/issues/6962 IC_kwDOAMm_X85JiU_j Illviljan 14371165 2022-09-01T04:47:07Z 2022-09-01T04:50:39Z MEMBER

Python 3.8 is used here. Is it something like this we're running into? https://stackoverflow.com/questions/62871524/is-pep-585-unusable-at-runtime-under-python-3-7-and-3-8

Maybe adding another mypy workflow for 3.8 would be a good idea?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type errors in `mypy` GitHub Action 1353466624
1229560785 https://github.com/pydata/xarray/issues/6962#issuecomment-1229560785 https://api.github.com/repos/pydata/xarray/issues/6962 IC_kwDOAMm_X85JSZvR lukeconibear 19871268 2022-08-28T21:46:55Z 2022-08-28T21:46:55Z CONTRIBUTOR

Which mypy version are you using?

0.971

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type errors in `mypy` GitHub Action 1353466624
1229559892 https://github.com/pydata/xarray/issues/6962#issuecomment-1229559892 https://api.github.com/repos/pydata/xarray/issues/6962 IC_kwDOAMm_X85JSZhU headtr1ck 43316012 2022-08-28T21:41:15Z 2022-08-28T21:41:15Z COLLABORATOR

Which mypy version are you using?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type errors in `mypy` GitHub Action 1353466624

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);