issue_comments

Table actions

5 rows where issue = 1328259769 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • update numpy version requirement · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1206383107 https://github.com/pydata/xarray/issues/6875#issuecomment-1206383107 https://api.github.com/repos/pydata/xarray/issues/6875 IC_kwDOAMm_X85H5_ID smoors 7092865 2022-08-05T12:20:09Z 2022-08-05T12:20:09Z NONE

Do people really look into the setup.cfg file when installing a package?

yes, especially people like me who do central software installations in a HPC cluster (for example with EasyBuild) and who want to have full control over the package versions that are installed (which is essential for scientific reproducibility). this is indeed a small minority, but note that a lot of people are using our centrally installed packages.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update numpy version requirement 1328259769
1206362047 https://github.com/pydata/xarray/issues/6875#issuecomment-1206362047 https://api.github.com/repos/pydata/xarray/issues/6875 IC_kwDOAMm_X85H55-_ headtr1ck 43316012 2022-08-05T11:53:31Z 2022-08-05T11:53:31Z COLLABORATOR

maybe you could add a comment to the setup.cfg file along the lines of "recommended numpy version >= 1.22" to better indicate this?

Do people really look into the setup.cfg file when installing a package? I would assume >99% of the people simply do pip/conda install xarray But I guess a comment does not hurt anyone.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update numpy version requirement 1328259769
1205334996 https://github.com/pydata/xarray/issues/6875#issuecomment-1205334996 https://api.github.com/repos/pydata/xarray/issues/6875 IC_kwDOAMm_X85H1_PU smoors 7092865 2022-08-04T14:28:37Z 2022-08-04T14:28:37Z NONE

As clearly stated in the documentation that you linked the supported methods depend on your installed numpy version.

indeed, I should have read the docs more carefully.

it's a bit annoying though: from the requirements I expected that numpy 1.19 would provide full support for all methods that xarray provides. maybe you could add a comment to the setup.cfg file along the lines of "recommended numpy version >= 1.22" to better indicate this?

I am not a direct user of this package, I just install it for our HPC users, but your suggestions to improve the error message and docs seem good to me.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update numpy version requirement 1328259769
1205292116 https://github.com/pydata/xarray/issues/6875#issuecomment-1205292116 https://api.github.com/repos/pydata/xarray/issues/6875 IC_kwDOAMm_X85H10xU keewis 14808389 2022-08-04T13:54:32Z 2022-08-04T14:00:09Z MEMBER

we could probably have a nicer error message, the one from numpy might be a bit confusing: pytb ValueError: interpolation can only be 'linear', 'lower' 'higher', 'midpoint', or 'nearest' Maybe something like this? pytb ValueError: interpolation method '{method}' requires numpy >= 1.22

Edit: while we're at it, we could also make that caveat in the docstring a bit easier to see by moving it to its own paragraph within the the parameter description, and actually add a literal * somewhere

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update numpy version requirement 1328259769
1205282926 https://github.com/pydata/xarray/issues/6875#issuecomment-1205282926 https://api.github.com/repos/pydata/xarray/issues/6875 IC_kwDOAMm_X85H1yhu headtr1ck 43316012 2022-08-04T13:47:44Z 2022-08-04T13:47:44Z COLLABORATOR

What exactly is the problem? As clearly stated in the documentation that you linked the supported methods depend on your installed numpy version.

The oldest numpys version that will be supported is at least 18 month old, so 1.19 is still correct.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   update numpy version requirement 1328259769

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);