issue_comments

Table actions

3 rows where issue = 1326509734 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Handle None in assert_valid_xy · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1204463757 https://github.com/pydata/xarray/pull/6871#issuecomment-1204463757 https://api.github.com/repos/pydata/xarray/issues/6871 IC_kwDOAMm_X85HyqiN Illviljan 14371165 2022-08-03T20:44:15Z 2022-08-03T20:45:33Z MEMBER

``` __ ERROR at teardown of testassert_valid_xy _____ [gw1] linux -- Python 3.8.13 /home/runner/micromamba/envs/xarray-tests/bin/python

@pytest.fixture(scope="function", autouse=True)
def test_all_figures_closed():
    """meta-test to ensure all figures are closed at the end of a test

    Notes:  Scope is kept to module (only invoke this function once per test
    module) else tests cannot be run in parallel (locally). Disadvantage: only
    catches one open figure per run. May still give a false positive if tests
    are run in parallel.
    """
    yield None

  open_figs = len(plt.get_fignums())

E NameError: name 'plt' is not defined ``` Hmm, strange error. _assert_valid_xy has no matplotlib stuff so there should be no need to make sure all figures are closed. Oh well just adding the requires_matlplotlib solves this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle None in assert_valid_xy 1326509734
1204087274 https://github.com/pydata/xarray/pull/6871#issuecomment-1204087274 https://api.github.com/repos/pydata/xarray/issues/6871 IC_kwDOAMm_X85HxOnq Illviljan 14371165 2022-08-03T15:15:59Z 2022-08-03T20:32:46Z MEMBER

I was thinking that mypy failing is sufficient testing.

Edit: Was thinking of another PR. Added a test. :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle None in assert_valid_xy 1326509734
1204072996 https://github.com/pydata/xarray/pull/6871#issuecomment-1204072996 https://api.github.com/repos/pydata/xarray/issues/6871 IC_kwDOAMm_X85HxLIk dcherian 2448579 2022-08-03T15:06:34Z 2022-08-03T15:06:34Z MEMBER

Is there a test we can add?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle None in assert_valid_xy 1326509734

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);