issue_comments

Table actions

8 rows where issue = 1315959612 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Fix numpy 1.20 incompatibility · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1200294960 https://github.com/pydata/xarray/pull/6821#issuecomment-1200294960 https://api.github.com/repos/pydata/xarray/issues/6821 IC_kwDOAMm_X85Hiwww Illviljan 14371165 2022-07-30T21:11:41Z 2022-07-30T21:11:41Z MEMBER

Thanks, @headtr1ck !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix numpy 1.20 incompatibility 1315959612
1193384057 https://github.com/pydata/xarray/pull/6821#issuecomment-1193384057 https://api.github.com/repos/pydata/xarray/issues/6821 IC_kwDOAMm_X85HIZh5 headtr1ck 43316012 2022-07-24T19:56:07Z 2022-07-24T19:56:07Z COLLABORATOR

When we bump the minimum numpy version to 1.20 we should rework the npcompat module since much of it is no longer required. But yet, we can do that in another PR.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix numpy 1.20 incompatibility 1315959612
1193383580 https://github.com/pydata/xarray/pull/6821#issuecomment-1193383580 https://api.github.com/repos/pydata/xarray/issues/6821 IC_kwDOAMm_X85HIZac max-sixty 5635139 2022-07-24T19:52:25Z 2022-07-24T19:52:25Z MEMBER

Sorry, I just read through #6818, mea culpa. It's really unlucky to have a "hole" between releases that pass!

If we've already done the work, then we may as well merge? And then after the next release we can bump the version, such that our latest release for numpy 1.20 works?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix numpy 1.20 incompatibility 1315959612
1193378283 https://github.com/pydata/xarray/pull/6821#issuecomment-1193378283 https://api.github.com/repos/pydata/xarray/issues/6821 IC_kwDOAMm_X85HIYHr Illviljan 14371165 2022-07-24T19:19:42Z 2022-07-24T19:22:54Z MEMBER

We follow https://numpy.org/neps/nep-0029-deprecation_policy.html, can read more here https://docs.xarray.dev/en/stable/getting-started-guide/installing.html

Seems we could increase the min numpy version if we wanted too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix numpy 1.20 incompatibility 1315959612
1193375611 https://github.com/pydata/xarray/pull/6821#issuecomment-1193375611 https://api.github.com/repos/pydata/xarray/issues/6821 IC_kwDOAMm_X85HIXd7 headtr1ck 43316012 2022-07-24T19:03:37Z 2022-07-24T19:03:37Z COLLABORATOR

Are we still supporting numpy 1.20? If we are, presumably it should be covered in our min-versions CI?

We are supporting >=1.19. Is there a rule when older versions are dropped?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix numpy 1.20 incompatibility 1315959612
1193371841 https://github.com/pydata/xarray/pull/6821#issuecomment-1193371841 https://api.github.com/repos/pydata/xarray/issues/6821 IC_kwDOAMm_X85HIWjB Illviljan 14371165 2022-07-24T18:38:23Z 2022-07-24T18:48:44Z MEMBER

If you do a temporary tweak (numpy=1.20) to the environment.yml in https://github.com/pydata/xarray/tree/main/ci/requirements the CI should run with those settings.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix numpy 1.20 incompatibility 1315959612
1193371320 https://github.com/pydata/xarray/pull/6821#issuecomment-1193371320 https://api.github.com/repos/pydata/xarray/issues/6821 IC_kwDOAMm_X85HIWa4 max-sixty 5635139 2022-07-24T18:34:40Z 2022-07-24T18:34:40Z MEMBER

Are we still supporting numpy 1.20? If we are, presumably it should be covered in our min-versions CI?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix numpy 1.20 incompatibility 1315959612
1193359918 https://github.com/pydata/xarray/pull/6821#issuecomment-1193359918 https://api.github.com/repos/pydata/xarray/issues/6821 IC_kwDOAMm_X85HITou headtr1ck 43316012 2022-07-24T17:16:47Z 2022-07-24T17:16:47Z COLLABORATOR

Verified locally that numpy 1.20 works. Is there a way to run a custom CI run with numpy 1.20?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix numpy 1.20 incompatibility 1315959612

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);