issue_comments

Table actions

5 rows where issue = 1305351232 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Switch to T_DataArray and T_Dataset in concat · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1186138098 https://github.com/pydata/xarray/pull/6784#issuecomment-1186138098 https://api.github.com/repos/pydata/xarray/issues/6784 IC_kwDOAMm_X85Gswfy rhkleijn 32801740 2022-07-16T09:58:05Z 2022-07-16T09:58:05Z CONTRIBUTOR

Is there any trick to avoid this or should I just close this for now?

Casting arr.rename(name) to T_DataArray using typing.cast might work until the mypy bug is fixed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Switch to T_DataArray and T_Dataset in concat 1305351232
1185904968 https://github.com/pydata/xarray/pull/6784#issuecomment-1185904968 https://api.github.com/repos/pydata/xarray/issues/6784 IC_kwDOAMm_X85Gr3lI headtr1ck 43316012 2022-07-15T20:44:05Z 2022-07-15T20:44:05Z COLLABORATOR

It should only affect the user when they use custom subclasses of DataArrays, something that is discouraged anyway.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Switch to T_DataArray and T_Dataset in concat 1305351232
1185891909 https://github.com/pydata/xarray/pull/6784#issuecomment-1185891909 https://api.github.com/repos/pydata/xarray/issues/6784 IC_kwDOAMm_X85Gr0ZF Illviljan 14371165 2022-07-15T20:29:19Z 2022-07-15T20:29:19Z MEMBER

The fact that these two doesn't always match each other should affect the user no?

Is there any trick to avoid this or should I just close this for now?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Switch to T_DataArray and T_Dataset in concat 1305351232
1185814117 https://github.com/pydata/xarray/pull/6784#issuecomment-1185814117 https://api.github.com/repos/pydata/xarray/issues/6784 IC_kwDOAMm_X85GrhZl headtr1ck 43316012 2022-07-15T18:47:22Z 2022-07-15T18:47:22Z COLLABORATOR

I think several method were not changed to T_DataArray due to the open mypy bug python/mypy#12846 which would lead to false positives on user side. rename might be one of them.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Switch to T_DataArray and T_Dataset in concat 1305351232
1185493369 https://github.com/pydata/xarray/pull/6784#issuecomment-1185493369 https://api.github.com/repos/pydata/xarray/issues/6784 IC_kwDOAMm_X85GqTF5 Illviljan 14371165 2022-07-15T12:23:38Z 2022-07-15T12:23:38Z MEMBER

xarray/core/concat.py:486: error: List comprehension has incompatible type List[Dataset]; expected List[T_Dataset] [misc] xarray/core/concat.py:618: error: Incompatible return value type (got "Dataset", expected "T_Dataset") [return-value] xarray/core/concat.py:654: error: Incompatible types in assignment (expression has type "DataArray", variable has type "T_DataArray") [assignment]

https://github.com/pydata/xarray/blob/c190b36ceda84b0af0e7f30c009233cda1af2b48/xarray/core/concat.py#L486 https://github.com/pydata/xarray/blob/c190b36ceda84b0af0e7f30c009233cda1af2b48/xarray/core/concat.py#L618 https://github.com/pydata/xarray/blob/c190b36ceda84b0af0e7f30c009233cda1af2b48/xarray/core/concat.py#L654

Slightly annoying errors here. .rename returns DataArray but apparently that not's a T_DataArray. What's the trick to avoid this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Switch to T_DataArray and T_Dataset in concat 1305351232

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);