issue_comments

Table actions

6 rows where issue = 1303371718 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Cannot open dataset with empty list units · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1265999976 https://github.com/pydata/xarray/issues/6781#issuecomment-1265999976 https://api.github.com/repos/pydata/xarray/issues/6781 IC_kwDOAMm_X85LdaBo dcherian 2448579 2022-10-03T20:32:05Z 2022-10-03T20:32:05Z MEMBER

I think this is now fixed by #7085 (thanks @ghislainp )

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot open dataset with empty list units 1303371718
1183325505 https://github.com/pydata/xarray/issues/6781#issuecomment-1183325505 https://api.github.com/repos/pydata/xarray/issues/6781 IC_kwDOAMm_X85GiB1B dcherian 2448579 2022-07-13T14:52:19Z 2022-07-13T14:52:19Z MEMBER

It is checking to see if we can decode it as a time variable

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot open dataset with empty list units 1303371718
1183323527 https://github.com/pydata/xarray/issues/6781#issuecomment-1183323527 https://api.github.com/repos/pydata/xarray/issues/6781 IC_kwDOAMm_X85GiBWH antscloud 57914115 2022-07-13T14:50:43Z 2022-07-13T14:50:43Z CONTRIBUTOR

I was wondering why the units attribute is parsed this way in the first place ? It seems that this attribute is converted to a Python object (a list), is it xarray that does this or the binding of netcdf4 ?

If it's xarray, wouldn't it be better to just not parse it ? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot open dataset with empty list units 1303371718
1183298330 https://github.com/pydata/xarray/issues/6781#issuecomment-1183298330 https://api.github.com/repos/pydata/xarray/issues/6781 IC_kwDOAMm_X85Gh7Ma dcherian 2448579 2022-07-13T14:29:06Z 2022-07-13T14:29:06Z MEMBER

I guess we could take a PR to change python if "units" in attrs and attrs["units"] in TIME_UNITS: to python if "units" in attrs and isinstance(attrs["units"], str) and attrs["units"] in TIME_UNITS:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot open dataset with empty list units 1303371718
1183244993 https://github.com/pydata/xarray/issues/6781#issuecomment-1183244993 https://api.github.com/repos/pydata/xarray/issues/6781 IC_kwDOAMm_X85GhuLB antscloud 57914115 2022-07-13T13:45:20Z 2022-07-13T13:45:20Z CONTRIBUTOR

@antscloud As a workaround you could use keyword argument decode_cf=False in the call to xr.open_dataset. After fixing the units attribute to some reasonable value you can call ds = xr.decode_cf(ds).

Thank you, i'll do this. One could just loop over variables attributes and replace [] by an empty string in this particular case

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot open dataset with empty list units 1303371718
1183218215 https://github.com/pydata/xarray/issues/6781#issuecomment-1183218215 https://api.github.com/repos/pydata/xarray/issues/6781 IC_kwDOAMm_X85Ghnon kmuehlbauer 5821660 2022-07-13T13:22:16Z 2022-07-13T13:22:16Z MEMBER

@antscloud As a workaround you could use keyword argument decode_cf=False in the call to xr.open_dataset. After fixing the units attribute to some reasonable value you can call ds = xr.decode_cf(ds). 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Cannot open dataset with empty list units 1303371718

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);